Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-921: Update Atata.WebDriverSetup package to v3.1.0 and enable Edge tests again #427

Merged
merged 2 commits into from
Nov 21, 2024
Merged

OSOE-921: Update Atata.WebDriverSetup package to v3.1.0 and enable Edge tests again #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a5f37a
Update Atata.WebDriverSetup package to v3.1.0
Piedone Nov 21, 2024
a8426eb
Revert "Skipping Edge tests"
Piedone Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ public Task VerifyBlogImage() =>
// is the different rendering of text on each platform, but it can occur between different Linux distributions too.
// Here: https://pandasauce.org/post/linux-fonts/ you can find a good summary about this from 2019, but still valid
// in 2022.
// Temporarily not running Edge until https://github.com/atata-framework/atata-webdriversetup/issues/16 is fixed.
[Theory, Chrome]
[Theory, Chrome, Edge]
public Task VerifyNavbar(Browser browser) =>
ExecuteTestAfterSetupAsync(
context =>
Expand Down
7 changes: 2 additions & 5 deletions Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,15 @@ public MultiBrowserTests(ITestOutputHelper testOutputHelper)

// First, let's see a test using Edge. While the default browser is Chrome if you don't set anything, all
// ExecuteTest* methods can also accept a browser, if you want to use a different one.
#pragma warning disable xUnit1004 // Test methods should not be skipped
[Fact(Skip = "Temporarily not running Edge until https://github.com/atata-framework/atata-webdriversetup/issues/16 is fixed.")]
#pragma warning restore xUnit1004 // Test methods should not be skipped
[Fact]
public Task AnonymousHomePageShouldExistWithEdge() =>
ExecuteTestAfterSetupAsync(NavbarIsCorrect, Browser.Edge);

// This test is now marked not with the [Fact] attribute but [Theory]. With it, you can create so-called data-driven
// tests. [Chrome] and [Edge] are input parameters of the test, and thus in effect, you have now two tests:
// AnonymousHomePageShouldExistMultiBrowser once with Chrome, and once with Edge. See here for more info:
// https://andrewlock.net/creating-parameterised-tests-in-xunit-with-inlinedata-classdata-and-memberdata/.
// Temporarily not running Edge until https://github.com/atata-framework/atata-webdriversetup/issues/16 is fixed.
[Theory, Chrome]
[Theory, Chrome, Edge]
public Task AnonymousHomePageShouldExistMultiBrowser(Browser browser) =>
ExecuteTestAfterSetupAsync(NavbarIsCorrect, browser);

Expand Down
2 changes: 1 addition & 1 deletion Lombiq.Tests.UI/Lombiq.Tests.UI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
<PackageReference Include="Atata.Bootstrap" Version="3.0.0" />
<PackageReference Include="Atata.HtmlValidation" Version="3.1.0" />
<PackageReference Include="Atata.WebDriverExtras" Version="3.0.0" />
<PackageReference Include="Atata.WebDriverSetup" Version="2.14.0" />
<PackageReference Include="Atata.WebDriverSetup" Version="3.1.0" />
<PackageReference Include="Azure.Storage.Blobs" Version="12.19.1" />
<PackageReference Include="Ben.Demystifier" Version="0.4.1" />
<PackageReference Include="Codeuctivity.ImageSharpCompare" Version="4.0.258" />
Expand Down
Loading