OSOE-867: Addressing analyzer warnings

Lombiq.Tests.UI.Shortcuts/Controllers/ApplicationInfoController.cs

@@ -7,7 +7,7 @@ namespace Lombiq.Tests.UI.Shortcuts.Controllers;
 [ApiController]
 [Route("api/ApplicationInfo")]
 [DevelopmentAndLocalhostOnly]
-public class ApplicationInfoController : Controller
+public class ApplicationInfoController : ControllerBase
 {
     private readonly IApplicationContext _applicationContext;
 

Lombiq.Tests.UI.Shortcuts/Controllers/InteractiveModeController.cs

@@ -2,6 +2,7 @@
 using Lombiq.Tests.UI.Shortcuts.Services;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
+using Microsoft.AspNetCore.Routing;
 
 namespace Lombiq.Tests.UI.Shortcuts.Controllers;
 

Lombiq.Tests.UI/Extensions/HtmlValidationResultExtensions.cs

@@ -16,7 +16,7 @@ public static async Task<IEnumerable<string>> GetErrorsAsync(this HtmlValidation
     {
         if (string.IsNullOrEmpty(result.ResultFilePath) || !File.Exists(result.ResultFilePath))
         {
-            return Enumerable.Empty<string>();
+            return [];
         }
 
         var fullOutput = await File.ReadAllTextAsync(result.ResultFilePath);

Lombiq.Tests.UI/Extensions/ShortcutsUITestContextExtensions.cs

@@ -270,7 +270,7 @@ public static Task EnableFeatureDirectlyAsync(
 
                 var feature = extensionManager.GetFeature(featureId);
 
-                return shellFeatureManager.EnableFeaturesAsync(new[] { feature }, force: true);
+                return shellFeatureManager.EnableFeaturesAsync([feature], force: true);
             },
             tenant,
             activateShell);
@@ -292,7 +292,7 @@ public static Task DisableFeatureDirectlyAsync(
 
                 var feature = extensionManager.GetFeature(featureId);
 
-                return shellFeatureManager.DisableFeaturesAsync(new[] { feature }, force: true);
+                return shellFeatureManager.DisableFeaturesAsync([feature], force: true);
             },
             tenant,
             activateShell);
@@ -489,7 +489,7 @@ public static Task SetThemeDirectlyAsync(
 
                 if (!isEnabled)
                 {
-                    await shellFeatureManager.EnableFeaturesAsync(new[] { themeFeature }, force: true);
+                    await shellFeatureManager.EnableFeaturesAsync([themeFeature], force: true);
                 }
             },
             tenant,

Lombiq.Tests.UI/Extensions/WebApplicationInstanceExtensions.cs

@@ -25,7 +25,7 @@ public static async Task LogsShouldBeEmptyAsync(
         CancellationToken cancellationToken = default)
     {
         if (cancellationToken == default) cancellationToken = CancellationToken.None;
-        permittedErrorLines ??= Array.Empty<string>();
+        permittedErrorLines ??= [];
 
         var logOutput = await webApplicationInstance.GetLogOutputAsync(cancellationToken);
 

Lombiq.Tests.UI/Pages/OrchardCoreAdminPage.cs

@@ -1,8 +1,13 @@
 using Atata;
 using Lombiq.Tests.UI.Components;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Lombiq.Tests.UI.Pages;
 
+[SuppressMessage(
+    "Major Code Smell",
+    "S1144:Unused private types or members should be removed",
+    Justification = "Atata requires private setters: https://atata.io/examples/page-object-inheritance/.")]
 public abstract class OrchardCoreAdminPage<TOwner> : Page<TOwner>
     where TOwner : OrchardCoreAdminPage<TOwner>
 {

Lombiq.Tests.UI/Pages/OrchardCoreContentItemsPage.cs

@@ -1,5 +1,6 @@
 using Atata;
 using Atata.Bootstrap;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Lombiq.Tests.UI.Pages;
 
@@ -8,6 +9,10 @@ namespace Lombiq.Tests.UI.Pages;
 using _ = OrchardCoreContentItemsPage;
 #pragma warning restore IDE0065 // Misplaced using directive
 
+[SuppressMessage(
+    "Major Code Smell",
+    "S1144:Unused private types or members should be removed",
+    Justification = "Atata requires private setters: https://atata.io/examples/page-object-inheritance/.")]
 public class OrchardCoreContentItemsPage : OrchardCoreAdminPage<_>
 {
     [FindById("new-dropdown")]

Lombiq.Tests.UI/Pages/OrchardCoreFeaturesPage.cs

@@ -1,6 +1,7 @@
 using Atata;
 using Atata.Bootstrap;
 using Lombiq.Tests.UI.Components;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Lombiq.Tests.UI.Pages;
 
@@ -9,6 +10,10 @@ namespace Lombiq.Tests.UI.Pages;
 using _ = OrchardCoreFeaturesPage;
 #pragma warning restore IDE0065 // Misplaced using directive
 
+[SuppressMessage(
+    "Major Code Smell",
+    "S1144:Unused private types or members should be removed",
+    Justification = "Atata requires private setters: https://atata.io/examples/page-object-inheritance/.")]
 public sealed class OrchardCoreFeaturesPage : OrchardCoreAdminPage<_>
 {
     [FindById]

Lombiq.Tests.UI/Pages/OrchardCoreLoginPage.cs

@@ -2,6 +2,7 @@
 using Lombiq.Tests.UI.Components;
 using Lombiq.Tests.UI.Extensions;
 using Lombiq.Tests.UI.Services;
+using System.Diagnostics.CodeAnalysis;
 using System.Threading.Tasks;
 
 namespace Lombiq.Tests.UI.Pages;
@@ -13,6 +14,10 @@ namespace Lombiq.Tests.UI.Pages;
 
 [Url(DefaultUrl)]
 [TermFindSettings(Case = TermCase.Pascal, TargetAllChildren = true, TargetAttributeType = typeof(FindByIdAttribute))]
+[SuppressMessage(
+    "Major Code Smell",
+    "S1144:Unused private types or members should be removed",
+    Justification = "Atata requires private setters: https://atata.io/examples/page-object-inheritance/.")]
 public class OrchardCoreLoginPage : Page<_>
 {
     private const string DefaultUrl = "Login";

Lombiq.Tests.UI/Pages/OrchardCoreRegistrationPage.cs

@@ -4,6 +4,7 @@
 using Lombiq.Tests.UI.Extensions;
 using Lombiq.Tests.UI.Models;
 using Lombiq.Tests.UI.Services;
+using System.Diagnostics.CodeAnalysis;
 using System.Threading.Tasks;
 
 namespace Lombiq.Tests.UI.Pages;
@@ -15,6 +16,10 @@ namespace Lombiq.Tests.UI.Pages;
 
 [Url(DefaultUrl)]
 [TermFindSettings(Case = TermCase.Pascal, TargetAllChildren = true, TargetAttributeType = typeof(FindByNameAttribute))]
+[SuppressMessage(
+    "Major Code Smell",
+    "S1144:Unused private types or members should be removed",
+    Justification = "Atata requires private setters: https://atata.io/examples/page-object-inheritance/.")]
 public class OrchardCoreRegistrationPage : Page<_>
 {
     public const string DefaultUrl = "Register";

Lombiq.Tests.UI/Pages/OrchardCoreSetupPage.cs

@@ -4,6 +4,7 @@
 using Lombiq.Tests.UI.Extensions;
 using Lombiq.Tests.UI.Services;
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Threading.Tasks;
 
 namespace Lombiq.Tests.UI.Pages;
@@ -19,6 +20,10 @@ namespace Lombiq.Tests.UI.Pages;
     Case = TermCase.Pascal,
     TargetAllChildren = true,
     TargetAttributeTypes = [typeof(FindByIdAttribute), typeof(FindByNameAttribute)])]
+[SuppressMessage(
+    "Major Code Smell",
+    "S1144:Unused private types or members should be removed",
+    Justification = "Atata requires private setters: https://atata.io/examples/page-object-inheritance/.")]
 public sealed class OrchardCoreSetupPage : Page<_>
 {
     public const string DefaultPageTitle = "Setup";

Lombiq.Tests.UI/SecurityScanning/SecurityScanConfiguration.cs

@@ -38,11 +38,11 @@ public class SecurityScanConfiguration
     public bool UnusedDatabaseTechnologiesAreExcluded { get; private set; } = true;
 
     /// <summary>
-    /// Gets a value indicating whether the security scan should not visit the <see cref="ErrorController"/> to test
+    /// Gets or sets a value indicating whether the security scan should not visit the <see cref="ErrorController"/> to test
     /// for correct error handling. This is achieved by adding the error page URL to the configuration with <see
     /// cref="YamlDocumentExtensions.AddRequestor"/>.
     /// </summary>
-    public bool DontScanErrorPage { get; private set; }
+    public bool DontScanErrorPage { get; set; }
 
     internal SecurityScanConfiguration()
     {
@@ -327,11 +327,7 @@ internal async Task ApplyToPlanAsync(YamlDocument yamlDocument, UITestContext co
             //   pollPostData: ""
         }
 
-        // False positive: https://github.com/SonarSource/sonar-dotnet/issues/8510.
-#pragma warning disable S3878 // Arrays should not be created for params parameters
         yamlDocument.AddExcludePathsRegex([.. _excludedUrlRegexPatterns]);
-#pragma warning restore S3878 // Arrays should not be created for params parameters
-
         if (AdminIsExcluded) yamlDocument.AddExcludePathsRegex($".*{context.AdminUrlPrefix}.*");
 
         if (UnusedDatabaseTechnologiesAreExcluded)

Lombiq.Tests.UI/SecurityScanning/ZapManager.cs

@@ -136,8 +136,8 @@ public async Task<SecurityScanResult> RunSecurityScanAsync(
         _zapPort = await _portLeaseManager.LeaseAvailableRandomPortAsync();
         _testOutputHelper.WriteLineTimestampedAndDebug("Running ZAP on port {0}.", _zapPort);
 
-        cliParameters.AddRange(new object[]
-        {
+        cliParameters.AddRange(
+        [
             "--rm",
             "--volume",
             $"{mountedDirectoryPath}:{_zapWorkingDirectoryPath}:rw",
@@ -149,7 +149,7 @@ public async Task<SecurityScanResult> RunSecurityScanAsync(
             _zapWorkingDirectoryPath + yamlFileName,
             "-port",
             _zapPort,
-        });
+        ]);
 
         var stdErrBuffer = new StringBuilder();
 

Lombiq.Tests.UI/Services/OrchardCoreInstance.cs

@@ -120,7 +120,7 @@ public IEnumerable<IApplicationLog> GetLogs(CancellationToken cancellationToken
                     FullName = Path.GetFullPath(filePath),
                     ContentLoader = () => GetFileContentAsync(filePath, cancellationToken),
                 })
-            : Enumerable.Empty<IApplicationLog>();
+            : [];
     }
 
     public TService GetRequiredService<TService>() =>

Lombiq.Tests.UI/Services/RemoteInstance.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 
@@ -16,7 +15,7 @@ public sealed class RemoteInstance : IWebApplicationInstance
 
     public Task<Uri> StartUpAsync() => Task.FromResult(_baseUri);
 
-    public IEnumerable<IApplicationLog> GetLogs(CancellationToken cancellationToken = default) => Enumerable.Empty<IApplicationLog>();
+    public IEnumerable<IApplicationLog> GetLogs(CancellationToken cancellationToken = default) => [];
     public TService GetRequiredService<TService>() => throw new NotSupportedException();
     public Task PauseAsync() => throw new NotSupportedException();
     public Task ResumeAsync() => throw new NotSupportedException();

Lombiq.Tests.UI/Services/SqlServerManager.cs

@@ -164,7 +164,7 @@ public async Task TakeSnapshotAsync(
                 if (File.Exists(filePathLocal)) File.Delete(filePathLocal);
 
                 await Cli.Wrap("docker")
-                    .WithArguments(new[] { "cp", $"{containerName}:{filePathRemote}", filePathLocal })
+                    .WithArguments(["cp", $"{containerName}:{filePathRemote}", filePathLocal])
                     .ExecuteAsync();
             }