-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-770: Add support for structured html-validate output #354
Closed
Closed
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
701f901
Add parsed html-validate option
AydinE 0b2346c
Remove usings
AydinE 745b000
Set default formatter to JSON
AydinE 42fdc70
Update HtmlValidationConfiguration.cs
AydinE 9188495
Update HtmlValidationConfiguration.cs
AydinE 15cf04a
Update HtmlValidationConfiguration.cs
AydinE 926a779
Set output back to text for ResultFile
AydinE a698c1c
Update HtmlValidationConfiguration.cs
AydinE 3f71487
Update Configuration.md
AydinE 2a1cbb3
Update HtmlValidationUITestContextExtensions.cs
AydinE dd4577a
Merge branch 'dev' into issue/OSOE-770
AydinE 46f624c
Update HtmlValidationResultExtensions.cs
AydinE File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
using Azure.Core.Serialization; | ||
using System.Text.Json; | ||
using System.Text.Json.Serialization; | ||
|
||
namespace Lombiq.Tests.UI.Models; | ||
|
||
public class HtmlValidationError | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should be more specific too (like |
||
{ | ||
[JsonPropertyName("ruleId")] | ||
public string RuleId { get; set; } | ||
[JsonPropertyName("severity")] | ||
public int Severity { get; set; } | ||
[JsonPropertyName("message")] | ||
public string Message { get; set; } | ||
[JsonPropertyName("offset")] | ||
public int Offset { get; set; } | ||
[JsonPropertyName("line")] | ||
public int Line { get; set; } | ||
[JsonPropertyName("column")] | ||
public int Column { get; set; } | ||
[JsonPropertyName("size")] | ||
public int Size { get; set; } | ||
[JsonPropertyName("selector")] | ||
public string Selector { get; set; } | ||
[JsonPropertyName("ruleUrl")] | ||
public string RuleUrl { get; set; } | ||
[JsonPropertyName("context")] | ||
public JsonElement Context { get; set; } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a good idea to rename it to something more specific like
GetJsonParsedErrorsAsync
, if we would add more formatters.