Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-351: Offer security checks #322

Merged
merged 133 commits into from
Dec 5, 2023
Merged

OSOE-351: Offer security checks #322

merged 133 commits into from
Dec 5, 2023

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Nov 14, 2023 •
edited by jira bot
Loading

OSOE-351
Fixes #128

@github-actions github-actions bot changed the title Offer security checks OSOE-351: Offer security checks Nov 14, 2023
Piedone added 24 commits November 14, 2023 19:13
@Piedone
Temporarily not running retries
62c4233
@Piedone
Fixing ZAP network access under Linux
ed31832
@Piedone
Managing the ZapManager instance centrally
8af3f0d
@Piedone
Redirecting ZAP output to the test output
19cc147
@Piedone
Making SecurityScanShouldPass pass with simplified setup
f174c2f
@Piedone
Docs
d0ba4a8
@Piedone
Basics of using YAML config files
dd3ff19
@Piedone
Adding support for YAML config files
8c703cc
@Piedone
Running spiderAjax only for "modern" apps
1c6667a
@Piedone
Switching to the Blog recipe since ZAP has a bug with Coming Soon
540dc9e
@Piedone
Link to ZAP bug report
51f429d
@Piedone
Centralizing YAML paths
06d5560
@Piedone
More flexible YML manipulation
4fa49b9
@Piedone
Adding UITestContext extensions for security scans
e25d515
@Piedone
Nicer-looking reports
1ba4af9
@Piedone
Adding basics of separate docs page
821bf4a
@Piedone
Generating SARIF reports too
7c21ab1
@Piedone
Automatically setting report directories to the conventional one
754bd4c
@Piedone
Docs
694557f
@Piedone
Changing report theme to the less extravagant "corporate" one
06a7e02
@Piedone
Saving ZAP reports into the Failure Dump
06bbfe0
@Piedone
Adding the ability to assert on security scan results
c5fc663
@Piedone
Making SecurityScanShouldPass pass
4fbd32a
@Piedone
Docs
2c48541
@BenedekFarkas BenedekFarkas mentioned this pull request Nov 29, 2023
Merged
BenedekFarkas
BenedekFarkas requested changes Nov 30, 2023
View reviewed changes
Lombiq.Tests.UI/Services/UITestContext.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI/SecurityScanning/SecurityScanConfiguration.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI/SecurityScanning/SecurityScanConfiguration.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI/SecurityScanning/SecurityScanConfiguration.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI/SecurityScanning/SecurityScanConfiguration.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI/SecurityScanning/SecurityScanConfiguration.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI/SecurityScanning/ZapManager.cs Show resolved Hide resolved
Lombiq.Tests.UI/SecurityScanning/YamlDocumentExtensions.cs Outdated Show resolved Hide resolved
@BenedekFarkas
Copy link
Member

This is awesome, I'm super happy we're taking this step!

@Piedone
Copy link
Member Author

Piedone commented Nov 30, 2023

Thank you!

@BenedekFarkas
Copy link
Member

BTW worked like a charm from VS Text Explorer too!

@Piedone
Copy link
Member Author

Piedone commented Nov 30, 2023

Awesome!

Piedone added 11 commits November 30, 2023 20:34
@Piedone
Cleaning up the ZAP container after completion
1e2993d
@Piedone
Cleaning up the ZAP image too after completion
116bd83
@Piedone
Revert "Cleaning up the ZAP image too after completion"
462d7b1 
This reverts commit 116bd83.

It'd actually delete the image after every single test, making a new pull necessary for every test, which is wasteful. We can't reliably run something only after all tests finished, so we can't do this properly.
@Piedone
Adding shortcuts for configuring active scan rules
f0706cf
@Piedone
AddRequestor() docs clarification
c97657a
@Piedone
Adding SecurityScanConfiguration.AddAdditionalUri()
631b502
@Piedone
Docs on the "Cross Site Scripting (DOM Based)" active scan rule
558b6ad
@Piedone
Fixing that AdditionalUris wasn't applied to the YAML
b39e37e
@Piedone
MD, C# linting fixes
5f74805
@Piedone
Fixing MD indentation again
61d16f8
@Piedone
Code styling
b9fb086
@Piedone @BenedekFarkas
Removing outdated comment
72496e9 
Co-authored-by: Benedek Farkas <[email protected]>
@Piedone Piedone merged commit 659d8a3 into dev Dec 5, 2023
1 check passed
@sarahelsaig sarahelsaig mentioned this pull request Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenedekFarkas BenedekFarkas BenedekFarkas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offer security checks (OSOE-351)
2 participants
@Piedone @BenedekFarkas