-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-548: Upgrade to Orchard Core 1.6 in UI-Testing-Toolbox #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piedone
requested changes
Apr 28, 2023
Piedone
requested changes
May 1, 2023
Piedone
approved these changes
May 12, 2023
Piedone
approved these changes
May 17, 2023
Piedone
requested changes
May 21, 2023
Co-authored-by: Zoltán Lehóczky <[email protected]>
Piedone
approved these changes
May 22, 2023
Reverting Microsoft.Extensions.Configuration.* version changes
Piedone
approved these changes
Jun 10, 2023
Comment on lines
36
to
37
var testDirectory = new FileInfo(testFrame.GetFileName()); | ||
var testPath = testDirectory.Directory.FullName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not needed but Jocó removed them.
OSOE-641: Fix remaining issues for the Orchard Core 1.6 upgrade in UI-Testing-Toolbox
Piedone
approved these changes
Jun 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just marking the merge from issue/OSOE-641
.
Piedone
approved these changes
Jun 11, 2023
# Conflicts: # Lombiq.Tests.UI/Lombiq.Tests.UI.csproj
# Conflicts: # Lombiq.Tests.UI.Shortcuts/Lombiq.Tests.UI.Shortcuts.csproj # Lombiq.Tests.UI/Lombiq.Tests.UI.csproj
OSOE-647: Context extensions and By helpers.
# Conflicts: # Lombiq.Tests.UI/Lombiq.Tests.UI.csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-548