Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCORE-105: Removing workaround for Orchard bug that perhaps doesn't exist anymore #250

Merged
merged 4 commits into from
Jan 9, 2023
Merged

OCORE-105: Removing workaround for Orchard bug that perhaps doesn't exist anymore #250

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
493fd5d
Removing workaround for Orchard bug that perhaps doesn't exist anymore
Piedone Jan 8, 2023
c603482
Trying 5-second monkey testing time
Piedone Jan 8, 2023
26ccc37
Debug code
Piedone Jan 9, 2023
3a07d29
Revert debug code
Piedone Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Lombiq.Tests.UI.Samples/Tests/MonkeyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,6 @@ private static MonkeyTestingOptions CreateMonkeyTestingOptions() =>

private static bool IsValidAdminBrowserLogEntry(LogEntry logEntry) =>
OrchardCoreUITestExecutorConfiguration.IsValidBrowserLogEntry(logEntry) &&
// This is necessary to work around this bug: https://github.com/OrchardCMS/OrchardCore/issues/11420.
!logEntry.Message.ContainsOrdinalIgnoreCase(
"Blocked attempt to show a 'beforeunload' confirmation panel for a frame that never had a user gesture since its load.") &&
// Requests to /api/graphql without further parameters will fail with HTTP 400, but that's OK, since some
// parameters are required.
!logEntry.Message.ContainsOrdinalIgnoreCase("/api/graphql - Failed to load resource: the server responded with a status of 400");
Expand Down