OSOE-501: Enable further analyzer rules for better code styling control and more #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e test-analysis-failure workflow
….0 as its pre-installed on runners and needed for additional analyzers
…penParen is not a typo
…meter to false See: #16 (comment)
…voidUsingWriteHost
… in the test-analysis-failure workflow
…s errors in the test-analysis-failure workflow" This reverts commit 11b5985.
BenedekFarkas
commented
Jan 12, 2023
| @@ -9,6 +9,7 @@ on: | |||
|
|
|||
| jobs: | |||
| call-test-analysis-failure-nuget: | |||
| if: false | |||
There was a problem hiding this comment.
Temporary change to be reverted later.
…ling some others analyzers we don't need for now
0liver
reviewed
Jan 17, 2023
Lombiq.Analyzers.PowerShell/Rules/Measure-LineContinuation/Measure-LineContinuation.psm1
Outdated
Show resolved
Hide resolved
0liver
reviewed
Jan 17, 2023
Lombiq.Analyzers.PowerShell/Rules/Measure-LineContinuation/Measure-LineContinuation.psm1
Outdated
Show resolved
Hide resolved
0liver
reviewed
Jan 17, 2023
Lombiq.Analyzers.PowerShell/Rules/Measure-LineContinuation/Measure-LineContinuation.psm1
Show resolved
Hide resolved
0liver
reviewed
Jan 17, 2023
…ConstantString only once
…ted analyzer violations in the test-analysis-failure workflow
…sure-LineContinuation.psm1 Co-authored-by: 0liver <[email protected]>
0liver
reviewed
Jan 17, 2023
...nalyzers.PowerShell/Rules/Measure-AutomaticVariableAlias/Measure-AutomaticVariableAlias.psm1
Outdated
Show resolved
Hide resolved
…first positional parameter with piping
0liver
reviewed
Jan 18, 2023
...nalyzers.PowerShell/Rules/Measure-AutomaticVariableAlias/Measure-AutomaticVariableAlias.psm1
Show resolved
Hide resolved
0liver
reviewed
Jan 18, 2023
sarahelsaig
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-501
Fixes #16