Skip to content

Commit

Permalink
Merge pull request #128 from Lombiq/issue/OSOE-470
Browse files Browse the repository at this point in the history
OSOE-470: Remove false entries (actual typos) from spell checking allow lists
  • Loading branch information
BenedekFarkas authored Dec 12, 2022
2 parents dc27967 + a4e6100 commit c6bcfde
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Lombiq.DataTables/Assets/Scripts/lombiq-datatables.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
lengthChange: true,
scrollX: true,
dom: "<'row dataTables_buttons'<'col-md-12'B>>" +
"<'row dataTables_controls'<'col-md-6 dataTables_length'l><'col-md-6 dataTables_search'f>>" +
"<'row dataTables_controls'<'col-md-6 dataTables_length'l><'col-md-6 dataTables_search'f>>" + // #spell-check-ignore-line
"<'row dataTables_content'<'col-md-12't>>" +
"<'row dataTables_footer'<'col-md-12'ip>>",
buttons: useDefaultButtons,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ static ResourceManagementOptionsConfiguration()
_manifest
.DefineScript(ResourceNames.DataTables.AutoInit)
.SetDependencies(ResourceNames.DataTables.Bootstrap4, ResourceNames.DataTables.Bootstrap4Buttons)
.SetUrl(Lombiq + "jquery-datatables-autoinit.js")
.SetUrl(Lombiq + "jquery-datatables-autoinit.js") // #spell-check-ignore-line
.SetVersion("1.0");

_manifest
Expand Down
3 changes: 2 additions & 1 deletion Lombiq.DataTables/Services/DataTableDataProviderBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ protected static IEnumerable<DataTableRow> SubstituteByColumn(
.ToDictionary(
cell => cell.Name,
cell => cell.Regex is { } regex
? new JValue(cell.Token?.ToString().RegexReplace(regex.From, regex.To, RegexOptions.Singleline) ?? string.Empty)
? new JValue(cell.Token?.ToString().RegexReplace(regex.From, regex.To, RegexOptions.Singleline) // #spell-check-ignore-line
?? string.Empty)
: cell.Token)));

protected async Task RenderLiquidAsync(IEnumerable<DataTableRow> rowList, IList<string> liquidColumns)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public static IEnumerable<object[]> Data()
new[]
{
("Num||^.*$||{{ '$0' | date: '%m/%d/%Y' }}", "Dates", true),
("Cls||^.*$||{{ '$0' | downcase }}", "Magic Words", true),
("Cls||^.*$||{{ '$0' | downcase }}", "Magic Words", true), // #spell-check-ignore-line
},
$"{today},foo bar baz;01/01/1970,lorem ipsum dolor sit amet;12/31/2020,the quick brown fox"
.Split(';')
Expand Down
2 changes: 1 addition & 1 deletion Lombiq.DataTables/Views/Lombiq.DataTable.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
$(function () {
var templates = {};
$(".@templatesElementName > div[data-id]").each(function(index, element) {
templates[element.getAttribute('data-id')] = element.innerHTML.replace(/%7B%7Bdata%7D%7D/g, '@templatePlaceholder');
templates[element.getAttribute('data-id')] = element.innerHTML.replace(/%7B%7Bdata%7D%7D/g, '@templatePlaceholder'); // #spell-check-ignore-line
element.parentElement.removeChild(element);
});
Expand Down

0 comments on commit c6bcfde

Please sign in to comment.