Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMBQ-175: Fixing standalone , if headerValue is empty #69

Merged
merged 3 commits into from
Jun 8, 2023
Merged

LMBQ-175: Fixing standalone , if headerValue is empty #69

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8e8c09
Fixing standalone `,` if headerValue is empty
DemeSzabolcs Jun 6, 2023
c19413e
Merge remote-tracking branch 'origin/dev' into issue/LMBQ-175
DemeSzabolcs Jun 7, 2023
18285fc
Fixing warning in EnvironmentRobotsMiddleware
DemeSzabolcs Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Lombiq.Hosting.Tenants.EnvironmentRobots/Middlewares/EnvironmentRobotsMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,20 @@ public Task InvokeAsync(HttpContext context)
{
var headerValue = context.Response.Headers["X-Robots-Tag"].FirstOrDefault() ?? string.Empty;

var directives = new List<string> { headerValue };
var directives = new List<string>();

if (!string.IsNullOrEmpty(headerValue))
{
directives.Add(headerValue);
}

// False warning, since headerValue is initialized to string.Empty if it would be null.
#pragma warning disable S2259 // Null pointers should not be dereferenced
if (!headerValue.Contains("noindex"))
{
directives.Add("noindex");
}
#pragma warning restore S2259 // Null pointers should not be dereferenced

if (!headerValue.Contains("nofollow"))
{
Expand Down