NEST-422: Media storage quota management for OC sites #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemeSzabolcs
requested changes
Apr 18, 2023
Lombiq.Hosting.Tenants.MediaStorageManagement/Views/UploadFileSize.cshtml
Show resolved
Hide resolved
Lombiq.Hosting.Tenants.MediaStorageManagement/Views/UploadFileSize.cshtml
Show resolved
Hide resolved
Lombiq.Hosting.Tenants.MediaStorageManagement/Views/UploadFileSize.cshtml
Show resolved
Hide resolved
Lombiq.Hosting.Tenants.MediaStorageManagement/Views/UploadFileSize.cshtml
Show resolved
Hide resolved
| @@ -0,0 +1,56 @@ | |||
| using Lombiq.Hosting.Tenants.MediaStorageManagement.Service; | |||
There was a problem hiding this comment.
(Just commenting it here.)
Is there a way to see total available space/ remaining space somewhere in the UI? I think that would be important. I don't know if this is already in OC, but I don't see that you added something like that.
I guess that can be a separate issue or something.
There was a problem hiding this comment.
Yeah, that could be a new feature. I thought that I would add it, but then I realized that it should be fetched and updated after each upload async, so I didn't add it at the end.
There was a problem hiding this comment.
Could you please note this in a "Future" issue or somewhere?
DemeSzabolcs
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEST-422