OSOE-514: Deployment action with GitHub Actions and better configuration

[Piedone]

OSOE-514
Fixes #21.
Fixes #22.
Fixes #26.
Fixes #27.

[Piedone]

I'm not sure about this and the workflow being here vs LGHA, but it feels wrong to add such project-specific GHA code to the general LGHA.

[sarahelsaig]

dynamic 🤮🤮🤮

Could you replace this and the others below with stuff like this?

        var featureStep = JObject.FromObject(new
        {
            name = "Feature",
            enable = new[] { "Lombiq.Hosting.MediaTheme.Bridge", "Lombiq.Hosting.MediaTheme" },
        });

Or better yet, the recipeSteps could be a List<object> and then it'll get converted when it's passed to its holder object in CreateRecipeAndWriteIt(). Personally I'd replace the whole thing with POCOs, but at least we should get rid of that cursed keyword.

[Piedone]

Be not afraid!

I'm not sure if it was worth it, but I got rid of dynamic. I don't see why we'd use List<object> as the parameter in CreateRecipeAndWriteIt(), since we're building a piece of JSON, so using JArray and friends is adequate.

[sarahelsaig]

I'm not sure if it was worth it

It's always worth it, dynamic is from the devil.

I don't see why we'd use List as the parameter

All you do with recipeSteps is pass it into CreateRecipeAndWriteIt() where it becomes a property of an object that gets converted via its JObject.FromObject() anyway. So it's not actually necessary to convert the individual items one by one.

[Piedone]

I'd like to believe JObject.FromObject() doesn't need to work on converting a JArray to a JArray :). List<object> is really a catch-all, as mentioned I see the semantics of JArray more appropriate, and in practice there's no difference.

[sarahelsaig]

My point is about code simplicity, not performance. For example I figure it's better to do
JObject.From( { array = new List<object> { item1, item2, item3 } } ) than
JObject.From( { array = new JArray() { JObject.From(item1), JObject.From(item2), JObject.From(item3) } } )
I don't think littering the code with JSON-specific abstraction is helpful when you are just building an object.