Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-51: Moving boostrap stuff to UIKit. #64

Merged
merged 11 commits into from
Apr 21, 2022
Merged

SNOW-51: Moving boostrap stuff to UIKit. #64

merged 11 commits into from
Apr 21, 2022

Conversation

sarahelsaig
Copy link
Member

@sarahelsaig sarahelsaig changed the title SNOW-51: <bootstrap-split-button> SNOW-51: <bootstrap-split-button> tag helper Apr 14, 2022
barthamark
barthamark approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@barthamark barthamark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I'll merge it now, but it should be part of the UIKit module of ours.

@sarahelsaig
Copy link
Member Author

sarahelsaig commented Apr 20, 2022 •
edited
Loading

oks good and I'll merge it now, but it should be part of the UIKit module of ours.

I remembered HE already had a bootstrap component, though I think it predates UIKit.
What do, move both to UIKit? Now or in a separate issue?

EDIT: nvm I've started moving it.

@sarahelsaig sarahelsaig changed the title SNOW-51: <bootstrap-split-button> tag helper SNOW-51: Moving boostrap stuff to UIKit. Apr 20, 2022
@barthamark barthamark merged commit fdf5449 into dev Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barthamark barthamark barthamark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahelsaig @barthamark