Add support for Predefined List in Code Generation extension

[devlife]

Problem

When using the Code Generation extension, if a TextField with an editor of Predefined List outputs the following text

FIX ME! Couldn't determine the actual type to instantiate

However, the source code indicates that we should use type OrchardCore.ContentFields.Settings.ListValueOption

Resolution

When a JObject is passed into ConvertJToken we return a string using the name/value pair as the Name and Value properties respectively.

Screenshot

[Piedone]

Nice, thank you!

[devlife]

Added some smarter formatting to handle simple arrays. Let me know if I missed anything else.

[Piedone]

Thanks, almost perfect!

[Piedone]

Thank you!

[Piedone]

Any news on this in the meantime? There's very little missing.

[devlife]

Sorry I let this slip. I'll wrap it up this week.

[Piedone]

How about now? :)

[devlife]

@Piedone I made the requested updates. The changed file list looks crazy although I only changed a single file. Do you want me to close this and create a new PR?

[Piedone]

The target branch should now be dev; I've retargeted the PR and it looks good now, but please check. Also, please address #23 (comment).

[devlife]

@Piedone Updated to use ContainsOrdinalIgnoreCase()

[Piedone]

I mean, when #23 (comment) is also done ;).

[devlife]

@Piedone that change is already done unless I'm missing something.

_contentDefinitionManager.AlterPartDefinition("Test", part => part
    .WithField("Predefined", field => field
        .OfType("TextField")
        .WithDisplayName("Predefined")
        .WithEditor("PredefinedList")
        .WithPosition("0")
        .WithSettings(new TextFieldPredefinedListEditorSettings
        {
            Options = new[]
            {
                new ListValueOption
                {
                    Name = "One",
                    Value = "1",
                }
                new ListValueOption
                {
                    Name = "Two",
                    Value = "2",
                }
                new ListValueOption
                {
                    Name = "Three",
                    Value = "3",
                }
            },
            DefaultValue = "1",
        })
    )
    .WithField("Picker", field => field
        .OfType("ContentPickerField")
        .WithDisplayName("Picker")
        .WithPosition("1")
        .WithSettings(new ContentPickerFieldSettings
        {
            DisplayedContentTypes = new[]
            {
                "Article",
                "ContentMenuItem",
                "Paragraph",
            },
        })
    )
);

[Piedone]

I commented before your commit :). I'll check it out.

[Piedone]

Suggested change

	var format = $"{string.Join(string.Empty, Enumerable.Repeat(" ", indentationDepth + 4))}";
	var indentation = $"{string.Join(string.Empty, Enumerable.Repeat(" ", indentationDepth + 4))}";

[0liver]

You can simplify this by using this string constructor:

Suggested change

	var format = $"{string.Join(string.Empty, Enumerable.Repeat(" ", indentationDepth + 4))}";
	var indentation = new string(' ', indentationDepth + 4);

The same goes for the other occurence.

[0liver]

@devlife Did you see these suggestions?

[devlife]

Ah no I did not. I replaced the string.Join statements with the string ctor.

[devlife]

Hey guys. Any other changes you'd like to see?

[Piedone]

There are build errors, and #23 (comment) (the variable name) is not addressed.

[devlife]

I updated the variable name but it compiles without any issues for me. Can you point me to the build issues you're seeing?

[Piedone]

Well, now it compiles with your new commits ;). #23 (comment) is not addressed though.

[devlife]

comment 23 is addressed!

[Piedone]

Thanks for fixing the other occasions too!

[Piedone]

And it's released, also on NuGet: https://github.com/Lombiq/Helpful-Extensions/releases/tag/v2.1.0

[devlife]

Woohoo! That's awesome thanks so much for your help @Piedone @0liver

[0liver]

Thank YOU for your long wind!