OSOE-476: Extract inline javascript block into file, and register for usage in Lombiq.HelpfulExtensions #114
Conversation
….Extensions, setting the path of the .js file
Lombiq.HelpfulExtensions/Extensions/TargetBlank/Filters/TargetBlankFilter.cs
Outdated
Show resolved
Hide resolved
|
@TheHydes You can also commit the |
Since its optional, i would rather leave it out at this point. |
Well for the project to run on GH it's not needed, but in the long run it will be annoying for the developers, since it will be generated every time: And also as I linked it's commited in other submodules too. |
| (links[i].hostname !== currentHostname && | ||
| (!links[i].href.match(/^javascript:/i)))) { |
There was a problem hiding this comment.
This has been merged now, but there are superfluous parentheses here:
| (links[i].hostname !== currentHostname && | |
| (!links[i].href.match(/^javascript:/i)))) { | |
| links[i].hostname !== currentHostname && | |
| !links[i].href.match(/^javascript:/i)) { |
| window.addEventListener( | ||
| 'load', | ||
| () => { | ||
| window.setTimeout(targetBlank, 100); |
There was a problem hiding this comment.
Why is the timeout necessary?
There was a problem hiding this comment.
Oh, I see it was in the original source.
The whole setTimeout call shouldn't be necessary, though.
| "nodejsExtensions": { | ||
| "scripts": { | ||
| "source": "Assets/Scripts", | ||
| "target": "wwwroot/scripts" | ||
| } | ||
| }, |
There was a problem hiding this comment.
This whole configuration is superfluous, if you're willing to accept the default path wwwroot/js for JS files.
| "devDependencies": { | ||
| "eslint": "^8.25.0", | ||
| "eslint-config-airbnb-base": "^15.0.0", | ||
| "eslint-plugin-import": "^2.26.0", | ||
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-only-warn": "^1.0.3", | ||
| "eslint-plugin-promise": "^6.1.0" | ||
| } |
There was a problem hiding this comment.
When used as part of OSOCE, this whole block should not be here.
|
I've created #116 to address the above and some more. |
OSOE-476