Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-572: Add "Generate Reset Password Token" workflow activity #113

Merged
merged 8 commits into from
Feb 28, 2023
Merged

OSOE-572: Add "Generate Reset Password Token" workflow activity #113

merged 8 commits into from
Feb 28, 2023

Conversation

barthamark
Copy link
Member

@barthamark barthamark commented Feb 15, 2023 •
edited by jira bot
Loading

dministro
dministro approved these changes Feb 28, 2023
View reviewed changes
Lombiq.HelpfulExtensions/Extensions/Workflows/Activities/GenerateResetPasswordTokenTask.cs Outdated
WorkflowExecutionContext workflowContext,
ActivityContext activityContext)
{
var user = !string.IsNullOrEmpty(User.Expression)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is not necessary. See: https://github.com/OrchardCMS/OrchardCore/blob/68c5f85470ca1d9bd2663c011aa4f67138de2ab5/src/OrchardCore.Modules/OrchardCore.Workflows/Scripting/JavaScriptWorkflowScriptEvaluator.cs#L32

@dministro dministro merged commit 19cc2d4 into dev Feb 28, 2023
Piedone referenced this pull request Mar 24, 2023
@0liver
Merge pull request #122 from Lombiq/issue/OSOE-559-nuget
1c7de82 
OSOE-559: Update Node.js Extensions to latest 1.2.0 NuGet package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dministro dministro dministro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barthamark @dministro