Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core.js): pass logEntry to collapsed function #200

Merged
merged 2 commits into from
Feb 1, 2017

Conversation

jedwards1211
Copy link
Contributor

@jedwards1211 jedwards1211 commented Jan 15, 2017

so that I can implement a collapse function that collapses everything but entries with errors

@codecov-io
Copy link

codecov-io commented Jan 15, 2017

Current coverage is 8.80% (diff: 0.00%)

Merging #200 into master will not change coverage

@@            master      #200   diff @@
========================================
  Files            5         5          
  Lines          125       125          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits            11        11          
  Misses         114       114          
  Partials         0         0          

Powered by Codecov. Last update 9b4b039...c81ce8b

@jedwards1211
Copy link
Contributor Author

looks like the code coverage config is too strict for the minimal amount of tests that are currently present

@imevro
Copy link
Collaborator

imevro commented Jan 18, 2017

Yeah, really too strict. @grushetsky can you update it?

@jedwards1211 why do you need logEntry? Probably action is enough for your case?

@jedwards1211
Copy link
Contributor Author

@evgenyrodionov well, I hadn't realized that redux-logger does log errors even if an action is collapsed, so I'm not sure this is necessary. But I don't see a simple way to uncollapse actions that caused errors without access to logEntry or the error. Otherwise I'd have to redispatch the action on the old state and see if it throws...and redispatching an action isn't kosher (could trigger side effects in middleware)

@imevro imevro merged commit cae12d8 into LogRocket:master Feb 1, 2017
@imevro
Copy link
Collaborator

imevro commented Feb 1, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants