Log diff output directly instead of converting to string #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 9.32% (diff: 0.00%)@@ master #182 diff @@
========================================
Files 5 5
Lines 118 118
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 11 11
Misses 107 107
Partials 0 0
|
|
@grushetsky looks good to me |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when I enabled diffs that I was getting
[object Object]in the diffs. I made this change so that instead of stringifying the output fromdeep-diff, the values are sent directly tologger.log.I don't know about
consoleimplementations outside of Chrome, but Chrome's console works great at displaying the objects in a nice format for inspection.