Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@hasfield render argument in wrong place #63

Closed
aitormendez opened this issue Aug 7, 2021 · 1 comment · Fixed by #82
Closed

@hasfield render argument in wrong place #63

aitormendez opened this issue Aug 7, 2021 · 1 comment · Fixed by #82

Comments

@aitormendez
Copy link

@hasfield('my_field', 113)

render as

<?php if (get_field('my_field')[113]) : ?>

instead

<?php if (get_field('my_field', 113)) : ?>

Captura de pantalla 2021-08-07 a las 18 42 19
EHLOVader added a commit to EHLOVader/sage-directives that referenced this issue Nov 3, 2021
@EHLOVader
Fix issues with field, hasfield, isfield post ID parsing
374c00b 
Switching to is_numeric to identify ID values from strings, since the blade template is always parsed as a string and is_string wasn't catching IDs.

Fixes Log1x#44
Fixes Log1x#63
EHLOVader added a commit to EHLOVader/sage-directives that referenced this issue Nov 3, 2021
@EHLOVader
Fix issues with field, hasfield, isfield post ID parsing
19a3817 
Switching to is_numeric to identify ID values from strings, since the blade template is always parsed as a string and is_string wasn't catching IDs.

Fixes Log1x#44
Fixes Log1x#63
@EHLOVader EHLOVader mentioned this issue Nov 3, 2021
Closed
@EHLOVader
Copy link

@aitormendez do you know if #68 fixes your issue?

Can be tested with composer patches

@Log1x Log1x mentioned this issue Jul 29, 2023
Merged
@Log1x Log1x closed this as completed in #82 Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@EHLOVader @aitormendez