Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect end directives #13

Closed
codepuncher opened this issue Mar 20, 2019 · 1 comment
Closed

Incorrect end directives #13

codepuncher opened this issue Mar 20, 2019 · 1 comment

Comments

@codepuncher
Copy link

In the docs, some of the end directives are incorrect and causes PHP errors like

Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: syntax error, unexpected 'endif' (T_ENDIF)
@hasfield('list')
  <ul>
    @fields('list')
      <li>@sub('item')</li>
    @fields
  </ul>
@endfield

Should be

@hasfield('list')
  <ul>
    @fields('list')
      <li>@sub('item')</li>
    @endfields
  </ul>
@endfield

Took me an embarrassing amount of time to realise why the directives weren't working.

@Log1x
Copy link
Owner

Log1x commented Apr 3, 2019

Haha sorry. I'm pushing a new version soon and I'll take a look through the docs and see if I can't spot any other typos.

Log1x added a commit that referenced this issue Apr 29, 2019
Add support for Sage 10
Change get() to a protected function
Add @ROLE and @Endrole
Increase possible array depth by 1 on @sub and @hassub (Fixes #12)
Fix typo in docs (Fixes #13)
Change docs code block markup from `php` to `py` as it renders Blade a bit better with highlight.js
@Log1x Log1x closed this as completed Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants