-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add text and background color support #145
enhance: add text and background color support #145
Conversation
The latest changes on this look good! I'll try to test it sometime this week. :) |
Any expectations of when this will get merged? 👀 |
I'm a little confused by the output of the inlineStyle stuff to get spacing/etc. If I dump +"style": array:1 [▼
"spacing" => array:1 [▼
"padding" => array:4 [▼
"top" => "var:preset|spacing|70"
"right" => "var:preset|spacing|70"
"bottom" => "var:preset|spacing|70"
"left" => "var:preset|spacing|70"
]
]
] where each value is I think it was generally supposed to output the actual CSS var like Did something change between the initial PR and now? Am I missing something? Do we need to deserialize this ourselves? 😩 |
Actually there was more issues to it.
Updated stubs too. |
Nice! I will get to this when I wake up. Was waiting on this before I push a release. I think we could probably move the Also need to add color stuff to the construct block stub. |
Thats a good idea. Moved it into a Trait. |
chore(concerns): add docblock to `formatCss()`
No description provided.