Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature proposal: Organization Profile Edit Page #54

Open
V41SH opened this issue Jun 18, 2020 · 6 comments
Open

New Feature proposal: Organization Profile Edit Page #54

V41SH opened this issue Jun 18, 2020 · 6 comments
Labels
accepted frontend work related to frontend module:org

Comments

@V41SH
Copy link

V41SH commented Jun 18, 2020

Created an organization profile edit page.

Code: https://github.com/V41SH/repo/blob/master/Org%20edit/orgprofileedit.html
Implementation: https://codepen.io/V41SH/pen/QWyGRwY

@lockedup-bot
Copy link

lockedup-bot bot commented Jun 18, 2020

Thanks @V41SH, for raising the issue! 🙌
One of our team mates will revert on this soon. ✅

@YashKumarVerma
Copy link
Member

you can send the preview link of codepen only. serves the purpose. no need to send the code by uploading it on github.
@VershaCoder @tejan-singh @sonali-singh97 @hayat-tamboli @karankartikeya

@YashKumarVerma
Copy link
Member

Good work @V41SH
I'd recommend a few changes.
I think the format done by @VershaCoder in #45 should be done everywhere related to profile show/update. Checkout #57 , you can use this layout as well, and get the fields that you've written in your code.

Combine these two, then it'd be perfect 👍

@YashKumarVerma YashKumarVerma added frontend work related to frontend module:org proposal proposal for task labels Jun 18, 2020
@V41SH
Copy link
Author

V41SH commented Jun 21, 2020

Followed @VershaCoder 's general design.
Implementation: https://codepen.io/V41SH/pen/xxZExXN

@YashKumarVerma
Copy link
Member

YashKumarVerma commented Jun 21, 2020

Brilliant!

@YashKumarVerma YashKumarVerma added accepted and removed proposal proposal for task labels Jun 21, 2020
@YashKumarVerma
Copy link
Member

Send a pr for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted frontend work related to frontend module:org
Projects
None yet
Development

No branches or pull requests

2 participants