Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature proposal: Profile Page #45

Closed
VershaCoder opened this issue Jun 16, 2020 · 8 comments · Fixed by #65
Closed

New feature proposal: Profile Page #45

VershaCoder opened this issue Jun 16, 2020 · 8 comments · Fixed by #65
Labels
accepted frontend work related to frontend module:user related to users module

Comments

@VershaCoder
Copy link
Member

Child #18

Layout Preview : https://codepen.io/versha/pen/PoZGXjE
I just created a prototype, need to do styling and code refactoring.
HTML code: https://github.com/VershaCoder/FrontEndTasks/blob/master/ProfilePage.html

@YashKumarVerma

@YashKumarVerma YashKumarVerma added accepted frontend work related to frontend module:user related to users module labels Jun 16, 2020
@VershaCoder
Copy link
Member Author

@YashKumarVerma Let me know if anything else needs to be added, will do both styling and refactoring code parallelly.

@YashKumarVerma
Copy link
Member

Brilliant work @VershaCoder, however, there are a few recommendations:

  • Make the page full width, i.e. don't leave the margin on each side. (change container -> container-fluid)
  • Put the profile and name in a card

(done in the preview I've shared : https://codepen.io/the-frustated-man/details/NWxbaRm)

Include the details about the user only on the left side, below the profile card. The right side where about, hobbies etc is given, there the posts about the user would come.

@VershaCoder
Copy link
Member Author

Hi @YashKumarVerma
Updated the layout.
Layout preview:https://codepen.io/versha/pen/oNbYdgN but facing issue when I am trying to resize it, getting space between card components. I have debugged it from my end but could not find anything.
Something like the below image.
image

@YashKumarVerma
Copy link
Member

Hi @YashKumarVerma
Updated the layout.
Layout preview:https://codepen.io/versha/pen/oNbYdgN but facing issue when I am trying to resize it, getting space between card components. I have debugged it from my end but could not find anything.
Something like the below image.
image

Maythis this is because of of the image being too wide

@VershaCoder
Copy link
Member Author

@YashKumarVerma
Updated the profile Page:(https://codepen.io/versha/pen/vYLgQNV)
Kindly review and let me know if any change is required.

@YashKumarVerma
Copy link
Member

Good work, send a pr pelase.

@VershaCoder
Copy link
Member Author

done

@YashKumarVerma
Copy link
Member

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted frontend work related to frontend module:user related to users module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants