Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Llvm 9 update #2

Merged
merged 2 commits into from
Apr 19, 2020
Merged

Llvm 9 update #2

merged 2 commits into from
Apr 19, 2020

Conversation

DieGoldeneEnte
Copy link

Motivation for this change

With coreclr and irods fixed to llvmPackages_7 all packages using llvmPackages on linux can be build.

Things done

Tested bot packages using nix-build.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DieGoldeneEnte
coreclr: pin to llvmPackages_7
f1328f6 
coreclr needs to be compiled with clang 7, because of the internal
assembler.
I duplicated the change from 054dc14
here to prevent duplicating the commit.
@DieGoldeneEnte
irods: pin to llvmPackages_7
39c0cc9 
irods needs llvmPackages_7, because it uses boost160.
LnL7
LnL7 approved these changes Apr 19, 2020
View reviewed changes
Copy link
Owner

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged this pull request into LnL7:llvm-9-update Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DieGoldeneEnte @LnL7