Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: use symlinks for authorizedKeys options #976

Merged
merged 2 commits into from
Jul 10, 2024
Merged

ssh: use symlinks for authorizedKeys options #976

merged 2 commits into from
Jul 10, 2024

Commits on Jun 15, 2024

  1. ssh: use symlinks for authorizedKeys options 

    As explained in the changelog and activation check, the previous
implementation had a nasty security bug that made removing a user’s
authorized keys effectively a no‐op.
    @emilazy
    emilazy committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    b833d4a View commit details
    Browse the repository at this point in the history

  2. write-text: remove support for copy 

    This is a huge anti‐declarative footgun; `copy` files cannot
distinguish if a previous version is managed by nix-darwin, so they
can’t check the hash, so they’re prone to destroying data, and
copied files are not deleted when they’re removed from the system
configuration, which led to a security bug. Nothing else in‐tree
was using this functionality, so let’s make sure it doesn’t
cause any more bugs.
    @emilazy
    emilazy committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    36a15e8 View commit details
    Browse the repository at this point in the history