-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: remove lib.mdDoc #932
Conversation
Oh, stable means 23.05, not 23.11... |
Presumably we'd want to bump the stable channel here for the purpose of GitHub Actions? |
This seems to work great in terms of fixing that bug, so great job. I was able to install nix-darwin using the flake method on a clean installation of macOS Sonoma 14.4.1 (23E224). On my clean install, I noticed that it seems like ~ via 🐍 v3.11.8
❯ pkg-config --list-all
~ via 🐍 v3.11.8
❯ pkg-config --libs libsodium
Package libsodium was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsodium.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libsodium' found
~ via 🐍 v3.11.8
❯ echo $PKG_CONFIG_PATH
Not sure if related, so asking for guidance if I should open a separate issue. |
@yonkeltron I don't think that's related, you should open a new issue. FWIW on a fresh
|
You got it! I opened #934 and that should do it. Love, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated my setup here to use github:wegank/nix-darwin/mddoc-remove
and it fixed the error I was getting after flake update:
error: attribute 'mdDoc' missing
@tarc: Can confirm the approach below works for me as well.
|
Working for me as well |
Another working build here using |
^ It'll work now even without this change if you also update to the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These deprecated versions were already made unsupported by LnL7#932.
These deprecated versions were already made unsupported by LnL7#932.
These deprecated versions were already made unsupported by LnL7#932.
lib.mdDoc
has been removed in NixOS/nixpkgs#303841.