Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove lib.mdDoc #932

Merged
merged 1 commit into from
Apr 19, 2024
Merged

treewide: remove lib.mdDoc #932

merged 1 commit into from
Apr 19, 2024

Conversation

wegank
Copy link
Contributor

@wegank wegank commented Apr 14, 2024

lib.mdDoc has been removed in NixOS/nixpkgs#303841.

@wegank
Copy link
Contributor Author

wegank commented Apr 14, 2024

Oh, stable means 23.05, not 23.11...

@purcell
Copy link
Contributor

purcell commented Apr 15, 2024

Oh, stable means 23.05, not 23.11...

Presumably we'd want to bump the stable channel here for the purpose of GitHub Actions?

@yonkeltron
Copy link

This seems to work great in terms of fixing that bug, so great job. I was able to install nix-darwin using the flake method on a clean installation of macOS Sonoma 14.4.1 (23E224).

On my clean install, I noticed that it seems like pkg-config is broken. For example, I have several development libraries installed via my flake.nix and yet they aren't findable:

~ via 🐍 v3.11.8
❯ pkg-config --list-all

~ via 🐍 v3.11.8
❯ pkg-config --libs libsodium
Package libsodium was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsodium.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libsodium' found

~ via 🐍 v3.11.8
❯ echo $PKG_CONFIG_PATH

Not sure if related, so asking for guidance if I should open a separate issue.

@nwjsmith
Copy link

@yonkeltron I don't think that's related, you should open a new issue. FWIW on a fresh nix shell I also see the same behaviour:

$ nix shell nixpkgs#libsodium nixpkgs#pkg-config
$ pkg-config --libs libsodium
Package libsodium was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsodium.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libsodium' found

@yonkeltron
Copy link

@yonkeltron I don't think that's related, you should open a new issue.

You got it! I opened #934 and that should do it.

Love,
+Jonathan

Copy link

@tarc tarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated my setup here to use github:wegank/nix-darwin/mddoc-remove and it fixed the error I was getting after flake update:

error: attribute 'mdDoc' missing

dominikb1888 added a commit to dominikb1888/nixpkgs that referenced this pull request Apr 18, 2024
@dominikb1888
Copy link

@tarc: Can confirm the approach below works for me as well.

I just updated my setup here to use github:wegank/nix-darwin/mddoc-remove and it fixed the error I was getting after flake update:

error: attribute 'mdDoc' missing

na-son added a commit to na-son/nixos-config that referenced this pull request Apr 18, 2024
@na-son
Copy link

na-son commented Apr 18, 2024

Working for me as well

@hesthub
Copy link

hesthub commented Apr 19, 2024

Another working build here using github:wegank/nix-darwin/mddoc-remove

@purcell
Copy link
Contributor

purcell commented Apr 19, 2024

^ It'll work now even without this change if you also update to the latest nixpkgs-unstable. (But with lots of errors printed out.)

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enzime Enzime merged commit 9e7c20f into LnL7:master Apr 19, 2024
6 checks passed
@wegank wegank deleted the mddoc-remove branch April 19, 2024 16:26
emilazy added a commit to emilazy/nix-darwin that referenced this pull request Jun 13, 2024
These deprecated versions were already made unsupported by LnL7#932.
347Online pushed a commit to 347Online/nix-darwin that referenced this pull request Jun 16, 2024
These deprecated versions were already made unsupported by LnL7#932.
kamushadenes pushed a commit to kamushadenes/nix-darwin that referenced this pull request Jul 8, 2024
These deprecated versions were already made unsupported by LnL7#932.
na-son added a commit to na-son/nixos-config that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants