feat(nvprefs): add V-Sync and frame limiter options #3317
+137
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
changed the title
ReenigneArcher
requested changes
Oct 20, 2024
| @@ -114,6 +114,26 @@ const config = ref(props.config) | |||
| </select> | |||
| <div class="form-text">{{ $t('config.nvenc_h264_cavlc_desc') }}</div> | |||
| </div> | |||
|
|
|||
| <!-- Force disable V-Sync (NVAPI) --> | |||
| <div class="mb-3" v-if="platform === 'windows'"> | |||
There was a problem hiding this comment.
This one is fine, but I'm not sure why the one above is missing the conditional for the windows platform... or if any of them are even needed as the entire nvenc encoder is Windows only.
| } | ||
|
|
||
| // TODO: save current setting and restore it later | ||
| setting.u32CurrentValue = 60; // TODO: change this according to host refresh rate |
There was a problem hiding this comment.
I suppose you can get this from #2894 after it's merged.
|
|
I managed to try this and it worked as expected: it changed the settings for vsync and fps limit I'd need a bit more info on those things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title.
A lot of users are already setting frame limiter / disabling V-Sync in Nvidia Control Panel to reduce stutter with Sunshine.
However it would require to switch back and forth between:
This PR aims to make this automatic.
Screenshot
Will provide later
Issues Fixed or Closed
Will check later
Type of Change
.github/...)Checklist