Added .none the StringEncodingStrategy #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated _XMLElement.createRootElement to set ignoreEscaping parameter in call to element.toXMLString Updated toXMLString to pass along ignoreEscaping to _toXMLString Removed default value for ignoreEscaping in _toXMLString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated _XMLElement.createRootElement to set ignoreEscaping parameter in call to element.toXMLString
Updated toXMLString to pass along ignoreEscaping to _toXMLString
Removed default value for ignoreEscaping in _toXMLString
Changed options.stringEncodingStrategy != .deferredToString to options.stringEncodingStrategy == .cdata to be more explicit.
Added StringEncodingStrategy.none to provide option to user.
I was having an issue in which a URL String containing query params would encode the "&" to be "&" therefore ruining the URL. Using StringEncodingStrategy.cdata solved this issue, however, I implemented StringEncodingStrategy.none in order to provide a more human readable alternative. The logic to ignore encoding was already in place but it was never exposed in the XMLEncoder's API.