Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1 Add extension plugin parameter to controll submiting review after … #5

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

cosic
Copy link
Contributor

@cosic cosic commented Oct 19, 2024

…uploading the build file

🚀 Description

Realized the issue#4

📄 Motivation and Context

🧪 How Has This Been Tested?

I've build and upload the plugin in local maven repository and used on my project to upload and submit review the real build file.

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Toxa2033
Copy link
Collaborator

Toxa2033 commented Oct 21, 2024

Thank you for the pull request. There were some issues with code style that need to be fixed
https://github.com/Litres/samsung-publisher-gradle-plugin/actions/runs/11429735864/job/31823828607?pr=5

@cosic cosic requested a review from Toxa2033 October 21, 2024 15:04
@Toxa2033 Toxa2033 merged commit daed556 into Litres:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants