feat: avoid mut constraint for simulation #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losman0s
force-pushed
the
man0s/enable-parallel-exec-for-sim
branch
from
c685c97
to
736ee93
Compare
kevinheavey
requested changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where this is used as an a amnesiac executor, the
self muton the tx processing functions unnecessarily prevent parallelisation due to a single shared line.This PR splits the necessary code into a read-only branch that gets used by the
simulatefunction, and allows the removal ofmutfor self.It does introduce a bit of duplication between
execute_sanitized_transaction_readonlyandexecute_sanitized_transactionand the naming might be suboptimal. If you have proposal to make it cleaner on those points lmk.