LF-4038: The app crashes on the home page once the user saves the user profile without preferred language #3098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the user with a non-LF language changes their profile without setting a language,
language_preference
becomesundefined
in the Redux storeand thelitefarm_lang
key in local storage is set to undefined in saga, which causes a crash in the home page. (Thank you Joyce!)LiteFarm/packages/webapp/src/containers/WeatherBoard/utils/index.jsx
Lines 28 to 34 in 37d34df
(⬆️
lang
beingundefined
causes a crash)Changes
useLanguageOptions
hook to keeplanguage_preference
as is. Currently the selected option is becomingnull
for a non-LF language.option
tag to the last name input label.NOTE:
I realized that the selected gender does not reflect the newly saved language preference, so I created a ticket
Jira link: https://lite-farm.atlassian.net/browse/LF-4040
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: