Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4027: Add gender and birth year to user profile #3091

Merged

Conversation

SayakaOno
Copy link
Collaborator

@SayakaOno SayakaOno commented Jan 24, 2024

Description

  • create useGenderOptions hook and use it in components
  • add gender and birth year inputs to Account component
  • update the account story
  • update label User Address to Address and change the order of the inputs based on Loïc's suggestion

Jira link: https://lite-farm.atlassian.net/browse/LF-4027

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno self-assigned this Jan 24, 2024
@SayakaOno SayakaOno added the enhancement New feature or request label Jan 24, 2024
@SayakaOno SayakaOno force-pushed the LF-4027/Add_gender_and_birth_year_to_user_profile branch from 5c1698a to 85f67da Compare January 24, 2024 19:11
@SayakaOno SayakaOno marked this pull request as ready for review January 24, 2024 19:13
@SayakaOno SayakaOno requested review from a team as code owners January 24, 2024 19:13
@SayakaOno SayakaOno requested review from antsgar and Duncan-Brain and removed request for a team January 24, 2024 19:13
Copy link
Collaborator

@antsgar antsgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love the addition of the hook to avoid repeating the gender options everywhere 🙂

Copy link
Collaborator

@Duncan-Brain Duncan-Brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@Duncan-Brain Duncan-Brain merged commit bba3005 into integration Jan 25, 2024
4 checks passed
@Duncan-Brain Duncan-Brain deleted the LF-4027/Add_gender_and_birth_year_to_user_profile branch January 25, 2024 14:54
antsgar pushed a commit that referenced this pull request Jan 26, 2024
…h_year_to_user_profile

LF-4027: Add gender and birth year to user profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants