Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Fix Firefox icon, new Glow theme, bug fixes, refactors, and more #273

Merged
merged 34 commits into from
Oct 15, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Oct 10, 2021

Extra Large Lissy93 /REFACTOR/new-initial-config → Lissy93/dashy Commits: 34 | Files Changed: 38 | Additions: 762 🚚 Refactor

Category: Refactor

Overview
A whole bunch of small things, including:

Issue Number #163 #177 #274

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Oct 10, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 41dd3fe

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6169f65475050e0008c29acc

😎 Browse the preview: https://deploy-preview-273--dashy-dev.netlify.app

@liss-bot
Copy link
Collaborator

liss-bot commented Oct 10, 2021

Hi Lissy93! Thank you for contributing to Dashy! ✨

When making changes to the documentation, be sure to double check that:

  • Link and images URLs properly resolve
  • Your spelling and grammar is correct
  • Any markdown formatting is valid

You're making changes to the main server entry point. Please test the app thoroughly, as any misconfigurations here may cause the app to stop functioning.

When updating dependencies, take a moment to verify that there are not security issues associated with any added or modified packages. If adding a new dependency, ensure that it is totally necessary, and check the packages size is not too large, as this will increase overall bundle size.

Thank you for adding your dashboard to the showcase! 🌟

Thank you for contributing to Dashy's translations 💖

Thank you for contributing to Dashy's themes 🎨


I'm a bot, and this is an automated comment 🤖

@liss-bot liss-bot added the 🚚 Refactor [PR] Non-feature code-related updates and refactoring label Oct 10, 2021
@viezly
Copy link

viezly bot commented Oct 10, 2021

This pull request is split into 7 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • .github
  • /
  • docs
  • public
  • src
  • src/assets
  • src/components
  • src/utils

Repository owner deleted a comment from liss-bot Oct 11, 2021
@liss-bot
Copy link
Collaborator

Size Change: +2.95 kB (0%)

Total Size: 1.9 MB

Filename Size Change
./dist/css/dashy.********.css 21.5 kB +839 B (+4%)
./dist/js/dashy.********.js 99.1 kB +2.06 kB (+2%)
./dist/precache-********.d935cfbaac0cbfa595124ae235427b6b.js 0 B -3.46 kB (removed) 🏆
./dist/precache-********.9dfaf741265b48fd81bda76086d85b2a.js 3.46 kB +3.46 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./dist/css/chunk-********.6fea770a.css 98 B 0 B
./dist/css/chunk-********.a64c098d.css 348 B 0 B
./dist/css/chunk-********.f5d4b402.css 899 B 0 B
./dist/css/chunk-vendors.********.css 847 B 0 B
./dist/default.html 2.61 kB 0 B
./dist/index.html 1.13 kB +41 B (+4%)
./dist/js/chunk-********.6b00cc8e.js 406 B 0 B
./dist/js/chunk-********.ac3decfd.js 2.05 kB 0 B
./dist/js/chunk-********.38fd5bbc.js 591 B 0 B
./dist/js/chunk-vendors.********.js 1.77 MB 0 B
./dist/service-worker.js 621 B +2 B (0%)

compressed-size-action

@liss-bot
Copy link
Collaborator

yarn.lock changes

Summary

Status Count
ADDED 5
UPDATED 115
REMOVED 3
Click to toggle table visibility
Name Status Previous Current
@babel/code-frame UPDATED 7.14.5 7.15.8
@babel/core UPDATED 7.15.0 7.15.8
@babel/generator UPDATED 7.15.0 7.15.8
@babel/helper-annotate-as-pure UPDATED 7.14.5 7.15.4
@babel/helper-builder-binary-assignment-operator-visitor UPDATED 7.14.5 7.15.4
@babel/helper-compilation-targets UPDATED 7.15.0 7.15.4
@babel/helper-create-class-features-plugin UPDATED 7.15.0 7.15.4
@babel/helper-explode-assignable-expression UPDATED 7.14.5 7.15.4
@babel/helper-function-name UPDATED 7.14.5 7.15.4
@babel/helper-get-function-arity UPDATED 7.14.5 7.15.4
@babel/helper-hoist-variables UPDATED 7.14.5 7.15.4
@babel/helper-member-expression-to-functions UPDATED 7.15.0 7.15.4
@babel/helper-module-imports UPDATED 7.14.5 7.15.4
@babel/helper-module-transforms UPDATED 7.15.0 7.15.8
@babel/helper-optimise-call-expression UPDATED 7.14.5 7.15.4
@babel/helper-remap-async-to-generator UPDATED 7.14.5 7.15.4
@babel/helper-replace-supers UPDATED 7.15.0 7.15.4
@babel/helper-simple-access UPDATED 7.14.8 7.15.4
@babel/helper-skip-transparent-expression-wrappers UPDATED 7.14.5 7.15.4
@babel/helper-split-export-declaration UPDATED 7.14.5 7.15.4
@babel/helper-validator-identifier UPDATED 7.14.9 7.15.7
@babel/helper-wrap-function UPDATED 7.14.5 7.15.4
@babel/helpers UPDATED 7.15.3 7.15.4
@babel/parser UPDATED 7.15.3 7.15.8
@babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining UPDATED 7.14.5 7.15.4
@babel/plugin-proposal-async-generator-functions UPDATED 7.14.9 7.15.8
@babel/plugin-proposal-class-static-block UPDATED 7.14.5 7.15.4
@babel/plugin-proposal-decorators UPDATED 7.14.5 7.15.8
@babel/plugin-proposal-object-rest-spread UPDATED 7.14.7 7.15.6
@babel/plugin-proposal-private-property-in-object UPDATED 7.14.5 7.15.4
@babel/plugin-transform-classes UPDATED 7.14.9 7.15.4
@babel/plugin-transform-for-of UPDATED 7.14.5 7.15.4
@babel/plugin-transform-modules-commonjs UPDATED 7.15.0 7.15.4
@babel/plugin-transform-modules-systemjs UPDATED 7.14.5 7.15.4
@babel/plugin-transform-parameters UPDATED 7.14.5 7.15.4
@babel/plugin-transform-runtime UPDATED 7.15.0 7.15.8
@babel/plugin-transform-spread UPDATED 7.14.6 7.15.8
@babel/preset-env UPDATED 7.15.0 7.15.8
@babel/runtime UPDATED 7.15.3 7.15.4
@babel/template UPDATED 7.14.5 7.15.4
@babel/traverse UPDATED 7.15.0 7.15.4
@babel/types UPDATED 7.15.0 7.15.6
@sentry/browser UPDATED 6.11.0 6.13.3
@sentry/core UPDATED 6.11.0 6.13.3
@sentry/hub UPDATED 6.11.0 6.13.3
@sentry/minimal UPDATED 6.11.0 6.13.3
@sentry/tracing UPDATED 6.11.0 6.13.3
@sentry/types UPDATED 6.11.0 6.13.3
@sentry/utils UPDATED 6.11.0 6.13.3
@sentry/vue UPDATED 6.11.0 6.13.3
@types/json5 ADDED - 0.0.29
@types/node UPDATED 16.6.2 16.10.4
@types/webpack-dev-server UPDATED 3.11.5 3.11.6
@types/webpack UPDATED 4.41.30 4.41.31
@vue/babel-plugin-jsx UPDATED 1.0.6 1.1.0
ace-builds UPDATED 1.4.12 1.4.13
acorn UPDATED 8.4.1 8.5.0
ajv UPDATED 8.6.2 8.6.3
ansi-align UPDATED 3.0.0 3.0.1
ansi-regex UPDATED 5.0.0 5.0.1
array-includes UPDATED 3.1.3 3.1.4
array.prototype.flat UPDATED 1.2.4 1.2.5
autoprefixer UPDATED 9.8.6 9.8.8
babel-plugin-polyfill-corejs3 UPDATED 0.2.4 0.2.5
boxen UPDATED 5.0.1 5.1.2
browserslist UPDATED 4.16.8 4.17.3
caniuse-lite UPDATED 1.0.30001251 1.0.30001265
cli-spinners UPDATED 2.6.0 2.6.1
colorette REMOVED 1.3.0 -
core-js-compat UPDATED 3.16.2 3.18.3
core-js UPDATED 3.16.2 3.18.3
css-what UPDATED 5.0.1 5.1.0
deep-is UPDATED 0.1.3 0.1.4
domhandler UPDATED 4.2.0 4.2.2
domutils UPDATED 2.7.0 2.8.0
electron-to-chromium UPDATED 1.3.812 1.3.866
es-abstract UPDATED 1.18.5 1.19.1
eslint-module-utils UPDATED 2.6.2 2.7.0
eslint-plugin-import UPDATED 2.24.0 2.25.1
eslint-plugin-vue UPDATED 7.16.0 7.19.1
find-cache-dir UPDATED 3.3.1 3.3.2
follow-redirects UPDATED 1.14.3 1.14.4
get-symbol-description ADDED - 1.0.0
is-core-module UPDATED 2.6.0 2.7.0
is-glob UPDATED 4.0.1 4.0.3
is-shared-array-buffer ADDED - 1.0.1
is-weakref ADDED - 1.0.1
jsoneditor UPDATED 9.5.3 9.5.6
mime-db UPDATED 1.49.0 1.50.0
mime-types UPDATED 2.1.32 2.1.33
minipass UPDATED 3.1.3 3.1.5
node-releases UPDATED 1.1.75 1.1.77
node-watch UPDATED 0.7.1 0.7.2
nth-check UPDATED 2.0.0 2.0.1
object.entries UPDATED 1.1.4 1.1.5
object.getownpropertydescriptors UPDATED 2.1.2 2.1.3
object.values UPDATED 1.1.4 1.1.5
picocolors ADDED - 0.2.1
pkg-up REMOVED 2.0.0 -
postcss UPDATED 7.0.36 7.0.39
read-pkg-up REMOVED 3.0.0 -
regenerate-unicode-properties UPDATED 8.2.0 9.0.0
regexpu-core UPDATED 4.7.1 4.8.0
regjsparser UPDATED 0.6.9 0.7.0
sass UPDATED 1.38.0 1.42.1
signal-exit UPDATED 3.0.3 3.0.5
simple-icons UPDATED 5.12.0 5.18.0
sockjs-client UPDATED 1.5.1 1.5.2
source-map-support UPDATED 0.5.19 0.5.20
string-width UPDATED 4.2.2 4.2.3
string.prototype.padend UPDATED 3.1.2 3.1.3
strip-ansi UPDATED 6.0.0 6.0.1
table UPDATED 6.7.1 6.7.2
tsconfig-paths UPDATED 3.10.1 3.11.0
unicode-canonical-property-names-ecmascript UPDATED 1.0.4 2.0.0
unicode-match-property-ecmascript UPDATED 1.0.4 2.0.0
unicode-match-property-value-ecmascript UPDATED 1.2.0 2.0.0
unicode-property-aliases-ecmascript UPDATED 1.1.0 2.0.0
vue-eslint-parser UPDATED 7.10.0 7.11.0
vue-i18n UPDATED 8.25.0 8.26.1
vue-loader-v16 UPDATED 16.5.0 16.8.1
vue-select UPDATED 3.12.2 3.13.2
ws UPDATED 7.5.3 7.5.5

@liss-bot
Copy link
Collaborator

@liss-bot Please mind your language.

Repository owner deleted a comment from liss-bot Oct 15, 2021
Repository owner deleted a comment from liss-bot Oct 15, 2021
Repository owner deleted a comment from liss-bot Oct 15, 2021
@liss-bot
Copy link
Collaborator

yarn.lock changes

Summary

Status Count
ADDED 5
UPDATED 124
REMOVED 3
Click to toggle table visibility
Name Status Previous Current
@babel/code-frame UPDATED 7.14.5 7.15.8
@babel/core UPDATED 7.15.0 7.15.8
@babel/generator UPDATED 7.15.0 7.15.8
@babel/helper-annotate-as-pure UPDATED 7.14.5 7.15.4
@babel/helper-builder-binary-assignment-operator-visitor UPDATED 7.14.5 7.15.4
@babel/helper-compilation-targets UPDATED 7.15.0 7.15.4
@babel/helper-create-class-features-plugin UPDATED 7.15.0 7.15.4
@babel/helper-explode-assignable-expression UPDATED 7.14.5 7.15.4
@babel/helper-function-name UPDATED 7.14.5 7.15.4
@babel/helper-get-function-arity UPDATED 7.14.5 7.15.4
@babel/helper-hoist-variables UPDATED 7.14.5 7.15.4
@babel/helper-member-expression-to-functions UPDATED 7.15.0 7.15.4
@babel/helper-module-imports UPDATED 7.14.5 7.15.4
@babel/helper-module-transforms UPDATED 7.15.0 7.15.8
@babel/helper-optimise-call-expression UPDATED 7.14.5 7.15.4
@babel/helper-remap-async-to-generator UPDATED 7.14.5 7.15.4
@babel/helper-replace-supers UPDATED 7.15.0 7.15.4
@babel/helper-simple-access UPDATED 7.14.8 7.15.4
@babel/helper-skip-transparent-expression-wrappers UPDATED 7.14.5 7.15.4
@babel/helper-split-export-declaration UPDATED 7.14.5 7.15.4
@babel/helper-validator-identifier UPDATED 7.14.9 7.15.7
@babel/helper-wrap-function UPDATED 7.14.5 7.15.4
@babel/helpers UPDATED 7.15.3 7.15.4
@babel/parser UPDATED 7.15.3 7.15.8
@babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining UPDATED 7.14.5 7.15.4
@babel/plugin-proposal-async-generator-functions UPDATED 7.14.9 7.15.8
@babel/plugin-proposal-class-static-block UPDATED 7.14.5 7.15.4
@babel/plugin-proposal-decorators UPDATED 7.14.5 7.15.8
@babel/plugin-proposal-object-rest-spread UPDATED 7.14.7 7.15.6
@babel/plugin-proposal-private-property-in-object UPDATED 7.14.5 7.15.4
@babel/plugin-transform-classes UPDATED 7.14.9 7.15.4
@babel/plugin-transform-for-of UPDATED 7.14.5 7.15.4
@babel/plugin-transform-modules-commonjs UPDATED 7.15.0 7.15.4
@babel/plugin-transform-modules-systemjs UPDATED 7.14.5 7.15.4
@babel/plugin-transform-parameters UPDATED 7.14.5 7.15.4
@babel/plugin-transform-runtime UPDATED 7.15.0 7.15.8
@babel/plugin-transform-spread UPDATED 7.14.6 7.15.8
@babel/preset-env UPDATED 7.15.0 7.15.8
@babel/runtime UPDATED 7.15.3 7.15.4
@babel/template UPDATED 7.14.5 7.15.4
@babel/traverse UPDATED 7.15.0 7.15.4
@babel/types UPDATED 7.15.0 7.15.6
@sentry/browser UPDATED 6.11.0 6.13.3
@sentry/core UPDATED 6.11.0 6.13.3
@sentry/hub UPDATED 6.11.0 6.13.3
@sentry/minimal UPDATED 6.11.0 6.13.3
@sentry/tracing UPDATED 6.11.0 6.13.3
@sentry/types UPDATED 6.11.0 6.13.3
@sentry/utils UPDATED 6.11.0 6.13.3
@sentry/vue UPDATED 6.11.0 6.13.3
@types/json5 ADDED - 0.0.29
@types/node UPDATED 16.6.2 16.11.0
@types/webpack-dev-server UPDATED 3.11.5 3.11.6
@types/webpack UPDATED 4.41.30 4.41.31
@vue/babel-plugin-jsx UPDATED 1.0.6 1.1.0
@vue/babel-preset-app UPDATED 4.5.13 4.5.14
@vue/cli-overlay UPDATED 4.5.13 4.5.14
@vue/cli-plugin-babel UPDATED 4.5.13 4.5.14
@vue/cli-plugin-eslint UPDATED 4.5.13 4.5.14
@vue/cli-plugin-pwa UPDATED 4.5.13 4.5.14
@vue/cli-plugin-router UPDATED 4.5.13 4.5.14
@vue/cli-plugin-vuex UPDATED 4.5.13 4.5.14
@vue/cli-service UPDATED 4.5.13 4.5.14
@vue/cli-shared-utils UPDATED 4.5.13 4.5.14
ace-builds UPDATED 1.4.12 1.4.13
acorn UPDATED 8.4.1 8.5.0
ajv UPDATED 8.6.2 8.6.3
ansi-align UPDATED 3.0.0 3.0.1
ansi-regex UPDATED 5.0.0 5.0.1
array-includes UPDATED 3.1.3 3.1.4
array.prototype.flat UPDATED 1.2.4 1.2.5
autoprefixer UPDATED 9.8.6 9.8.8
babel-plugin-polyfill-corejs3 UPDATED 0.2.4 0.2.5
boxen UPDATED 5.0.1 5.1.2
browserslist UPDATED 4.16.8 4.17.4
caniuse-lite UPDATED 1.0.30001251 1.0.30001267
cli-spinners UPDATED 2.6.0 2.6.1
colorette REMOVED 1.3.0 -
core-js-compat UPDATED 3.16.2 3.18.3
core-js UPDATED 3.16.2 3.18.3
css-what UPDATED 5.0.1 5.1.0
deep-is UPDATED 0.1.3 0.1.4
domhandler UPDATED 4.2.0 4.2.2
domutils UPDATED 2.7.0 2.8.0
electron-to-chromium UPDATED 1.3.812 1.3.870
es-abstract UPDATED 1.18.5 1.19.1
eslint-module-utils UPDATED 2.6.2 2.7.1
eslint-plugin-import UPDATED 2.24.0 2.25.2
eslint-plugin-vue UPDATED 7.16.0 7.19.1
find-cache-dir UPDATED 3.3.1 3.3.2
follow-redirects UPDATED 1.14.3 1.14.4
get-symbol-description ADDED - 1.0.0
is-core-module UPDATED 2.6.0 2.8.0
is-glob UPDATED 4.0.1 4.0.3
is-shared-array-buffer ADDED - 1.0.1
is-weakref ADDED - 1.0.1
jsoneditor UPDATED 9.5.3 9.5.6
mime-db UPDATED 1.49.0 1.50.0
mime-types UPDATED 2.1.32 2.1.33
minipass UPDATED 3.1.3 3.1.5
node-releases UPDATED 1.1.75 2.0.0
node-watch UPDATED 0.7.1 0.7.2
nth-check UPDATED 2.0.0 2.0.1
object.entries UPDATED 1.1.4 1.1.5
object.getownpropertydescriptors UPDATED 2.1.2 2.1.3
object.values UPDATED 1.1.4 1.1.5
picocolors ADDED - 1.0.0
pkg-up REMOVED 2.0.0 -
postcss UPDATED 7.0.36 7.0.39
read-pkg-up REMOVED 3.0.0 -
regenerate-unicode-properties UPDATED 8.2.0 9.0.0
regexpu-core UPDATED 4.7.1 4.8.0
regjsparser UPDATED 0.6.9 0.7.0
sass UPDATED 1.38.0 1.43.2
signal-exit UPDATED 3.0.3 3.0.5
simple-icons UPDATED 5.12.0 5.18.0
sockjs-client UPDATED 1.5.1 1.5.2
source-map-support UPDATED 0.5.19 0.5.20
string-width UPDATED 4.2.2 4.2.3
string.prototype.padend UPDATED 3.1.2 3.1.3
strip-ansi UPDATED 6.0.0 6.0.1
table UPDATED 6.7.1 6.7.2
tsconfig-paths UPDATED 3.10.1 3.11.0
unicode-canonical-property-names-ecmascript UPDATED 1.0.4 2.0.0
unicode-match-property-ecmascript UPDATED 1.0.4 2.0.0
unicode-match-property-value-ecmascript UPDATED 1.2.0 2.0.0
unicode-property-aliases-ecmascript UPDATED 1.1.0 2.0.0
vue-eslint-parser UPDATED 7.10.0 7.11.0
vue-i18n UPDATED 8.25.0 8.26.5
vue-loader-v16 UPDATED 16.5.0 16.8.1
vue-select UPDATED 3.12.2 3.13.3
ws UPDATED 7.5.3 7.5.5

Repository owner deleted a comment from liss-bot Oct 15, 2021
Repository owner deleted a comment from liss-bot Oct 15, 2021
Repository owner deleted a comment from liss-bot Oct 15, 2021
@Lissy93 Lissy93 self-assigned this Oct 15, 2021
@liss-bot
Copy link
Collaborator

Size Change: +43.1 kB (+2%)

Total Size: 1.94 MB

Filename Size Change
./dist/css/dashy.********.css 21.7 kB +1.02 kB (+5%) 🔍
./dist/js/chunk-********.6b00cc8e.js 0 B -406 B (removed) 🏆
./dist/js/chunk-********.ac3decfd.js 0 B -2.05 kB (removed) 🏆
./dist/js/chunk-********.38fd5bbc.js 0 B -591 B (removed) 🏆
./dist/js/chunk-vendors.********.js 1.81 MB +39.5 kB (+2%)
./dist/js/dashy.********.js 99.5 kB +2.46 kB (+3%)
./dist/precache-********.d935cfbaac0cbfa595124ae235427b6b.js 0 B -3.46 kB (removed) 🏆
./dist/js/chunk-********.f26de106.js 406 B +406 B (new file) 🆕
./dist/js/chunk-********.7d46509e.js 2.05 kB +2.05 kB (new file) 🆕
./dist/js/chunk-********.b26a5777.js 591 B +591 B (new file) 🆕
./dist/precache-********.5ebf4adffb9aec73efdd30f109f154d4.js 3.46 kB +3.46 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./dist/css/chunk-********.6fea770a.css 98 B 0 B
./dist/css/chunk-********.a64c098d.css 348 B 0 B
./dist/css/chunk-********.f5d4b402.css 899 B 0 B
./dist/css/chunk-vendors.********.css 847 B 0 B
./dist/default.html 2.61 kB 0 B
./dist/index.html 1.13 kB +42 B (+4%)
./dist/service-worker.js 618 B -1 B (0%)

compressed-size-action

@Lissy93 Lissy93 linked an issue Oct 15, 2021 that may be closed by this pull request
@Lissy93 Lissy93 merged commit 1469e4b into master Oct 15, 2021
@Lissy93 Lissy93 deleted the REFACTOR/new-initial-config branch October 15, 2021 22:13
@liss-bot
Copy link
Collaborator

The fix for this issue has now been released in Dashy 1.9.0 ✨

If you haven't done so already, please update your instance to 1.9.0 or later. See Dashy 1.9.0 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Fixed 🟥 PR - XL 🚚 Refactor [PR] Non-feature code-related updates and refactoring 🛩️ Released 1.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Favicon not loading, console errors
2 participants