Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] - Adds missing translations + small UI fixes #129

Merged
merged 14 commits into from
Aug 7, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 7, 2021

Lissy93 /FIX/missing-translations → Lissy93/dashy Commits: 14 | Files Changed: 16 | Additions: 17 Powered by Pull Request Badge

Category: Minor UI bug fixes and adds missing translations

Overview
79d8d1b 🌐 Re: #126 - Adds missing translations
9f33bac 🐛 Re: #127 - Fixes translations not being picked up in dropdown
7a669d6 🌐 Re: #126 - Implements missing translations for Login action
25289f3 ➖ Removes highlight.js, to reduce app size
1ea00ec 🔥 Removed obsolete lougout code, and adds translations
4ead7b6 🩹 Re: #123 - Fixes cut-off text
179c9ed 👨‍🚀 Adds Owners file for PR assignments
61a3e6b 👷 Adds GH action to assign reviewer based on code owner
c29e710 🩹 Fixed a bunch of minor UI things

Issue Number #123, #126 and #127

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 7, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 9b9d804

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/610ee0d6e5a91a00082ece06

😎 Browse the preview: https://deploy-preview-129--dashy-dev.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2021

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
highlight.js DOWNGRADED 11.1.0 10.7.3

@Lissy93 Lissy93 requested a review from liss-bot as a code owner August 7, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant