-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE_REQUEST] Option for removing Google Fonts #58
Comments
Heya, thanks for raising this. Yes some of the themes contain Google Fonts, as it was not feasible to bundle a ton of TTF files in the package. I will look into making fonts optional, it's on my to-do list :) In the meantime, you can either stick to just the default theme which has all the required fonts pre-bundled locally, or use ad/ tracker blocker and deny access to |
I've made an update to fix this, by replacing the CDN with local assets. You can switch to branch I did submit a PR (#60) for it, but am in two minds about weather to merge this. Although I'm the biggest hater of Google, using their CDN does mean that for most users these assets will already be cached on their system. Since font files are quite heavy, this has quite a serious impact on performance. I may think about it, and see if there's anything else that would make sense before I merge this. |
Thank you for the detailed response. Glad to see that someone else tries to avoid Google. Sadly your solution is not feasible for me since I'm running on your docker images and thus can't make use of your feature branch. |
Well for it to be done via config, then the font assets would need to be loaded with JavaScript, which isn't a great approach, as fonts have to be in a stylesheets root in order to be available immediately on page load. Maybe I'm missing something, if you know of an implementation method to conditionally load certain aspects of a stylesheet based on a property defined at runtime I would be very interested. It's easy to modify functionality using anything in the config file, but page styling, less so. And in terms of the Docker, you can run it from any branch, just build the container yourself- |
[REFACTOR] Use local font assets Requested by @Robert-Ernst in #58 - Fixed.
Heya @Robert-Ernst - Just to let you know I updated and merged the PR which removes all instances of fonts loading from the CDN. They're now all bundled within the project, and so loaded locally. There are still other parts of the app (all optional, and off by default) which make external requests. This includes the favicon-fetching (if your fetching for a public service), status checks (again, only if your checking for a public online website), Font-Awesome icons, generative icons, and the backup & sync functionality (if used). |
Co-authored-by: ImgBotApp <[email protected]>
Is your feature request related to a problem? If so, please describe.
I'm using uMatrix and it shows that font.googleapis.com and gstatic.com are getting called from my own server. Since we care about privacy this is not acceptable for us. We don't care much about the font quality. Any standard font would be fine. Is there any option yet to simply disable all calls towards Google?
Describe the solution you'd like
Implement an option to disable calls for Fonts to Google. Just default to any standard font instead.
Priority:
Medium: Would be useful
The text was updated successfully, but these errors were encountered: