Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Add Target Attribute to Nav Links #552

Closed
mkin701 opened this issue Mar 13, 2022 · 4 comments
Closed

[FEATURE_REQUEST] Add Target Attribute to Nav Links #552

mkin701 opened this issue Mar 13, 2022 · 4 comments
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change

Comments

@mkin701
Copy link

mkin701 commented Mar 13, 2022

Is your feature request related to a problem? If so, please describe.

While I'm waiting for the multi-view feature to be released I'm trying to link my 3 Dashy instances together using navigation links. This works great except for the fact I cannot set the links to open in the same tab which is not ideal. I think this would be an easy feature to add and useful for other things as well.

Describe the solution you'd like

It would be nice to have the target attribute available on the nav links in the top bar so links can be opened in the same tab as the dashboard.

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

No

@mkin701 mkin701 added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Mar 13, 2022
@liss-bot

This comment was marked as outdated.

@Lissy93 Lissy93 reopened this Mar 13, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Mar 13, 2022

Sure, will do :)

@Lissy93
Copy link
Owner

Lissy93 commented Mar 28, 2022

Heya @mkin701
Sorry for the delay in addressing this, have now implemented your request in #557
So you can now set the opening method of each nav link with the target attribute

E.g.

pageInfo:
  navLinks:
  - title: Workspace View
    path: /workspace
    target: sametab
  - title: Duck
    path: https://duck.com
    target: newtab

For more info, see config docs: pageInfo.navLinks
Feel free to reach out if you need anything else :)

@mkin701
Copy link
Author

mkin701 commented Mar 28, 2022

Heya @mkin701 Sorry for the delay in addressing this, have now implemented your request in #557 So you can now set the opening method of each nav link with the target attribute

E.g.

pageInfo:
  navLinks:
  - title: Workspace View
    path: /workspace
    target: sametab
  - title: Duck
    path: https://duck.com
    target: newtab

For more info, see config docs: pageInfo.navLinks Feel free to reach out if you need anything else :)

Thanks for adding this so quickly, will give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change
Projects
None yet
Development

No branches or pull requests

3 participants