Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pageInfo.title no longer displayed in browser tab #1544

Closed
5 tasks done
hulr opened this issue Apr 22, 2024 · 3 comments
Closed
5 tasks done

[BUG] pageInfo.title no longer displayed in browser tab #1544

hulr opened this issue Apr 22, 2024 · 3 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working

Comments

@hulr
Copy link

hulr commented Apr 22, 2024

Environment

Self-Hosted (Docker)

System

No response

Version

3.0.0

Describe the problem

After upgrading from 2.1.2 to 3.0.0 the title configured in pageInfo.title is no longer displayed in the browser tab.
As a workaround I defined the environment variable VUE_APP_TITLE which solves the issue.

I assume this is because of the recent changes to the makeMetaTags const: a1bf7a6#diff-d7f41ba1aa74f41ef4b0c2337abe593d08092ffae6528a8aa2db712afeee0b66L69-L72

Additional info

No response

Please tick the boxes

@hulr hulr added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Apr 22, 2024
@github-project-automation github-project-automation bot moved this to Awaiting Triage in Dashy V3 Apr 22, 2024
@Lissy93
Copy link
Owner

Lissy93 commented Apr 22, 2024

I assume this is because of the recent changes to the makeMetaTags const: a1bf7a6

You are correct. Since the config is now loaded at runtime, yet page title needs to go into the Vue router, which needs to be compiled, it was no longer possible to load that dynamically.

I've pushed an update (not merged yet), which will set the title (client-side) to whatever is in pageInfo.title. It will go live once #1542 is merged.

@mr-f0xx
Copy link

mr-f0xx commented Apr 22, 2024

I was about to post an issue about this haha thanks for this update, much appreciated

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 22, 2024
@Lissy93
Copy link
Owner

Lissy93 commented Apr 29, 2024

Fixed in 3.0.1 :)
Source: d58cde6

@Lissy93 Lissy93 closed this as completed Apr 29, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Triage to Done in Dashy V3 Apr 29, 2024
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants