Skip to content

Commit

Permalink
Merge pull request #40 from Lissy93/bug-fix_39-statuscheck-visibility
Browse files Browse the repository at this point in the history
[BUG-FIX] Status check tooltip visibility, Re: #39
  • Loading branch information
Lissy93 authored Jun 19, 2021
2 parents ca3d171 + a3a84e5 commit 3d37ec6
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 2 deletions.
2 changes: 2 additions & 0 deletions docs/theming.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ You can target specific elements on the UI with these variables. All are optiona
- `--welcome-popup-text-color` - Text color for the welcome pop-up. Defaults to `--primary`
- `--side-bar-background` - Background color of the sidebar used in the workspace view. Defaults to `--background-darker`
- `--side-bar-color` - Color of icons and text within the sidebar. Defaults to `--primary`
- `--status-check-tooltip-background` - Background color for status check tooltips. Defaults to `--background-darker`
- `--status-check-tooltip-color` - Text color for the status check tooltips. Defaults to `--primary`

#### Non-Color Variables
- `--outline-color` - Used to outline focused or selected elements
Expand Down
1 change: 1 addition & 0 deletions src/components/LinkItems/Item.vue
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export default {
html: false,
placement: this.statusResponse ? 'left' : 'auto',
delay: { show: 600, hide: 200 },
classes: 'item-description-tooltip',
};
},
/* Used by certain themes, which display an icon with animated CSS */
Expand Down
3 changes: 2 additions & 1 deletion src/components/LinkItems/StatusIndicator.vue
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ export default {

<style lang="scss">
.status-tooltip {
background: var(--background-darker) !important;
background: var(--status-check-tooltip-background) !important;
color: var(--status-check-tooltip-color) !important;
font-size: 1rem;
z-index: 10;
&.tip-green { border: 1px solid var(--success); }
Expand Down
2 changes: 2 additions & 0 deletions src/styles/color-palette.scss
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,6 @@
--side-bar-background: var(--background-darker);
--side-bar-background-lighter: var(--background);
--side-bar-color: var(--primary);
--status-check-tooltip-background: var(--background-darker);
--status-check-tooltip-color: var(--primary);
}
10 changes: 9 additions & 1 deletion src/styles/color-themes.scss
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ html[data-theme='material-original'] {
--config-settings-background: #01579b;
--config-settings-color: #fff;
--heading-text-color: #fff;
--status-check-tooltip-background: #f2f2f2;
--status-check-tooltip-color: #01579b;
}

html[data-theme='material-dark-original'] {
Expand Down Expand Up @@ -208,6 +210,8 @@ html[data-theme='material-dark-original'] {
--config-settings-color: #41e2ed;
--scroll-bar-color: #08B0BB;
--scroll-bar-background: #131a1f;
--status-check-tooltip-background: #131a1f;
--status-check-tooltip-color: #08B0BB;
&::-webkit-scrollbar-thumb {
border-left: 1px solid #131a1f;
}
Expand Down Expand Up @@ -331,7 +335,7 @@ html[data-theme='material'], html[data-theme='material-dark'] {
}
}
}
.tooltip {
.tooltip.item-description-tooltip {
display: none !important;
}
.orientation-horizontal {
Expand Down Expand Up @@ -498,6 +502,8 @@ html[data-theme='material-dark'] {
--config-settings-color: #41e2ed;
--scroll-bar-color: #08B0BB;
--scroll-bar-background: #131a1f;
--status-check-tooltip-color: #131a1f;

&::-webkit-scrollbar-thumb {
border-left: 1px solid #131a1f;
}
Expand Down Expand Up @@ -527,6 +533,8 @@ html[data-theme='minimal-light'] {
--search-container-background: #fff;
--curve-factor: 4px;
--curve-factor-navbar: 8px;
--status-check-tooltip-background: #f2f2f2;
--status-check-tooltip-color: #000;

section.filter-container {
background: #fff;
Expand Down

1 comment on commit 3d37ec6

@vercel
Copy link

@vercel vercel bot commented on 3d37ec6 Jun 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.