Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues identified during testing #31

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

nagdahimanshu
Copy link
Member

@nagdahimanshu nagdahimanshu commented Feb 23, 2024

What was the problem?

This PR resolves #30

How was it solved?

  • Errors are properly formatted (replace %w with %v)
  • Application should start with relative path when running with docker
  • Run fault detector from source code with custom config file works without any issue
  • Update config default host to 0.0.0.0 to be accessible when running with docker
  • Resolve status based on diverged flag from fault detector
    • Refactor server implementation to pass fault detector instance
    • Add implementation to validates if version specific handlers are registered before starting the server
  • Update addressRegex to support uppercase characters
  • Update Makefile
    • Updated docker run command to run container in background
    • Add docker stop command

How was it tested?

Local

@nagdahimanshu nagdahimanshu self-assigned this Feb 23, 2024
@nagdahimanshu nagdahimanshu force-pushed the 30-fix-issues-identified-during-testing branch 2 times, most recently from dd65078 to bac3a2d Compare February 26, 2024 08:56
@nagdahimanshu nagdahimanshu force-pushed the 30-fix-issues-identified-during-testing branch from bac3a2d to 825a0fe Compare February 26, 2024 10:26
@nagdahimanshu nagdahimanshu force-pushed the 30-fix-issues-identified-during-testing branch from 0b938dc to f31328d Compare February 26, 2024 14:58
@nagdahimanshu nagdahimanshu force-pushed the 30-fix-issues-identified-during-testing branch from 00b1aab to 30b9e21 Compare February 27, 2024 14:02
@nagdahimanshu nagdahimanshu marked this pull request as ready for review February 27, 2024 14:17
Makefile Outdated Show resolved Hide resolved
pkg/api/handlers/v1/status.go Show resolved Hide resolved
pkg/api/handlers/v1/status.go Show resolved Hide resolved
pkg/api/server.go Outdated Show resolved Hide resolved
pkg/api/server.go Show resolved Hide resolved
cmd/faultdetector/main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hrmhatef hrmhatef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small suggestion.

pkg/api/server.go Outdated Show resolved Hide resolved
@hrmhatef
Copy link
Contributor

Also I have another suggestion, we can remove the routes pkg an move the ping path to the server.go in the NewHTTPServer func, WDYT?

Copy link
Member

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi removed the request for review from ishantiw February 28, 2024 11:26
@sameersubudhi sameersubudhi merged commit f9dfa4e into main Feb 28, 2024
1 check passed
@sameersubudhi sameersubudhi deleted the 30-fix-issues-identified-during-testing branch February 28, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issues identified during testing
3 participants