-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme for fault detector app #28
Conversation
b612509
to
90b75f1
Compare
bd4b450
to
1ea82c1
Compare
7df7406
to
469d9d5
Compare
ab09bb8
to
de32303
Compare
Co-authored-by: Himanshu Nagda <[email protected]>
Co-authored-by: Himanshu Nagda <[email protected]>
de32303
to
fd7c4b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related this PR, but
2024-02-12T12:01:10+01:00 ERROR Failed at parsing config with error %!w(*errors.errorString=&{fix the following 1 config validation fail(s) to continue:
- notification.slack.channel_id expected to match regex: `^[A-Za-z0-9]{1,255}$`, received: ''})
2024-02-12T12:01:10+01:00 ERROR Failed to create app, %!w(*errors.errorString=&{fix the following 1 config validation fail(s) to continue:
- notification.slack.channel_id expected to match regex: `^[A-Za-z0-9]{1,255}$`, received: ''})
there is error due to config coming from other PR
@shuse2 Yes I found the error while testing and is fixed along with some minor bug in notification util. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What was the problem?
This PR resolves #24
How was it solved?