Update readme for fault detector app #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishantiw
force-pushed
the
24-update-readme
branch
4 times, most recently
from
b612509
to
90b75f1
Compare
ishantiw
force-pushed
the
24-update-readme
branch
2 times, most recently
from
bd4b450
to
1ea82c1
Compare
ishantiw
commented
Feb 9, 2024
ishantiw
force-pushed
the
24-update-readme
branch
2 times, most recently
from
7df7406
to
469d9d5
Compare
ishantiw
force-pushed
the
24-update-readme
branch
from
ab09bb8
to
de32303
Compare
shuse2
requested changes
Feb 12, 2024
Co-authored-by: Himanshu Nagda <[email protected]>
Co-authored-by: Himanshu Nagda <[email protected]>
ishantiw
force-pushed
the
24-update-readme
branch
from
de32303
to
fd7c4b2
Compare
shuse2
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Not related this PR, but
2024-02-12T12:01:10+01:00 ERROR Failed at parsing config with error %!w(*errors.errorString=&{fix the following 1 config validation fail(s) to continue:
- notification.slack.channel_id expected to match regex: `^[A-Za-z0-9]{1,255}$`, received: ''})
2024-02-12T12:01:10+01:00 ERROR Failed to create app, %!w(*errors.errorString=&{fix the following 1 config validation fail(s) to continue:
- notification.slack.channel_id expected to match regex: `^[A-Za-z0-9]{1,255}$`, received: ''})
there is error due to config coming from other PR
|
@shuse2 Yes I found the error while testing and is fixed along with some minor bug in notification util. |
shuse2
requested changes
Feb 12, 2024
shuse2
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #24
How was it solved?