Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update unlock command #7667

Closed
Tracked by #7622
shuse2 opened this issue Oct 19, 2022 · 2 comments · Fixed by #7711
Closed
Tracked by #7622

Update unlock command #7667

shuse2 opened this issue Oct 19, 2022 · 2 comments · Fixed by #7711
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Oct 19, 2022

Description

  • Update verify logic only to check params is empty
  • Check current other execute logic is aligned with the LIP

Acceptance Criteria

  • Update verify tests
@mosmartin
Copy link
Contributor

Hi @shuse2 the unlock command in the linked lip defines two functions/methods execute() & isUnlockable(). There is. no definition of a verify logic as stated above.

@shuse2
Copy link
Collaborator Author

shuse2 commented Oct 25, 2022

isUnlockable is private function, and execute is the hook. there is no verify in the LIP, but in implementation, we need to make sure params is empty in verify step

shuse2 pushed a commit that referenced this issue Nov 3, 2022
### What was the problem?

This PR resolves #7667

### How was it solved?

- Add verify()
- Add _isUnlockable()
- Refactor execute()
- Update constants
@shuse2 shuse2 modified the milestones: Sprint 81, Sprint 82 Nov 7, 2022
@shuse2 shuse2 closed this as completed Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants