Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update unlock command #7711

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

mosmartin
Copy link
Contributor

What was the problem?

This PR resolves #7667

How was it solved?

  • Add verify()
  • Add _isUnlockable()
  • Refactor execute()
  • Update constants

How was it tested?

@mosmartin mosmartin self-assigned this Oct 31, 2022
@mosmartin mosmartin changed the base branch from development to feature/7622-update-dpos-module October 31, 2022 16:16
- Add verify()
- Add _isUnlockable()
- Refactor execute()
- Update constants
framework/src/modules/dpos_v2/commands/unlock.ts Outdated Show resolved Hide resolved
framework/src/modules/dpos_v2/constants.ts Outdated Show resolved Hide resolved
framework/src/modules/dpos_v2/commands/unlock.ts Outdated Show resolved Hide resolved
framework/src/modules/dpos_v2/commands/unlock.ts Outdated Show resolved Hide resolved
@mosmartin mosmartin marked this pull request as ready for review November 2, 2022 11:49
@mosmartin mosmartin requested review from has5aan and removed request for has5aan November 2, 2022 11:49
@shuse2 shuse2 changed the title Update unlock command - Closes #7667 Update unlock command Nov 2, 2022
- Refactor the execute() method
- Cleanup the constants
- Add verify unit tests

:white_check_mark: Update the test message
@shuse2 shuse2 merged commit d35cb1f into feature/7622-update-dpos-module Nov 3, 2022
@shuse2 shuse2 deleted the 7667-update_unlock_command branch November 3, 2022 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update unlock command
3 participants