Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double broadcasting of the delegate registration transaction - Closes #4054 #4071

Merged
merged 5 commits into from
Jan 13, 2022
Merged

Prevent double broadcasting of the delegate registration transaction - Closes #4054 #4071

merged 5 commits into from
Jan 13, 2022

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Jan 13, 2022 •
edited
Loading

What was the problem?

This PR resolves #4054

How was it solved?

  • Removed unnecessary animations
  • Adapted the tx status component with the generic illustration. I did this since there's no reason to keep the user in the tx status screen till the tx is confirmed. we do not do this for any other tx, and we shouldn't do it for delegate reg either.
  • Also fixed the error report button for mutlsig txs in addition to the ticket title.

How was it tested?

  • Tested manually using normal and multisig accounts.
  • Removed obsolete unit tests.

@reyraa reyraa self-assigned this Jan 13, 2022
@reyraa reyraa removed the request for review from isalga January 13, 2022 09:54
@eniolam1000752
Copy link
Contributor

LGTM

@reyraa reyraa merged commit a91f60e into release/2.2.0 Jan 13, 2022
@reyraa reyraa deleted the 4054-fix-delegate-reg-result branch January 13, 2022 12:01
@reyraa reyraa mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eniolam1000752 eniolam1000752 eniolam1000752 approved these changes

@ikem-legend ikem-legend Awaiting requested review from ikem-legend

Assignees

@reyraa reyraa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyraa @eniolam1000752