Improve signing process for a fully signed transaction - Closes #4059 #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isalga
approved these changes
Jan 12, 2022
|
|
||
| it('should return the tx ready to be broadcasted', () => { | ||
| expect(signatureSkipped(props)).toEqual( | ||
| expect.objectContaining({ type: actionTypes.signatureSkipped }), |
There was a problem hiding this comment.
Would be good to add data: binaryTx be added to the assertion
There was a problem hiding this comment.
I don't perform any logic there and that part is actually extensively tested in utils/transaction.js. I think it's redundant, but if you still believe I have to test it I can add that too.
There was a problem hiding this comment.
Ah, one more thing, the use of flattenTransaction and createTransactionObject is really getting out of hand. We need a proper refactoring round there. I have to change all these tests anyways. Otherwise I don't know how we can handle the sapphire phase.
reyraa
force-pushed
the
4059-improve-signing-process
branch
from
fce2a4a
to
9e3c140
Compare
ManuGowda
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4059
How was it solved?
How was it tested?