Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix banned delegate profile errors - Closes #3977 #3994

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Fix banned delegate profile errors - Closes #3977 #3994

merged 2 commits into from
Dec 3, 2021

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Dec 2, 2021

What was the problem?

This PR resolves #3977

How was it solved?

  • We had a missing null check
  • React was complaining about a missing property that was removed form the component. I removed it from the propType.

How was it tested?

Visually.

@reyraa reyraa changed the base branch from development to release/2.2.0 December 2, 2021 15:43
@reyraa reyraa self-assigned this Dec 2, 2021
ikem-legend
ikem-legend approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@ikem-legend ikem-legend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@reyraa reyraa merged commit 20fb71c into release/2.2.0 Dec 3, 2021
@reyraa reyraa deleted the 3977-banned-delegate-bug branch December 3, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikem-legend ikem-legend ikem-legend approved these changes

@gadjacobs gadjacobs Awaiting requested review from gadjacobs

Assignees

@reyraa reyraa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Banned delegate profile throws an error
2 participants
@reyraa @ikem-legend