Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual issues detected in 2.0.0-alpha.7 - Closes #3535 #3536

Merged
merged 113 commits into from
May 21, 2021

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented May 5, 2021

What was the problem?

This PR resolves #3535

How was it solved?

  • In Sign-in page: the custom node information is not retained
  • In Network statistics page: WS and Version are not listed in the grid
  • In Transaction page: Crashed! ' An error occurred'
  • In Delegates monitoring page: Outside round tab, Sorting is wrong and also can we re-introduce the rank column (both inside and outside round tabs)?
  • In Delegates monitoring page: Watched tab. Forging time and Round state is not getting updated
  • In Wallet page: Hotspot for copy address, request LSK (others also) is not good enough
  • In Wallet page: Unable to see the old address. The functionality is not working
  • In Transaction summary page: the transaction fee is incorrect -> Can't reproduce
  • Transfer transaction and Vote transaction are taking too much time for confirmation and sometimes it fails
  • Recent Lisk transactions in dashboard is not working
  • Create unlock tx fails
  • Recent Lisk transactions in dashboard is not working
  • Multiple errors are thrown when the account signs out
  • Unable to do any transfer transaction using bookmarked accounts
  • Unable to unlock the vote amount. Page crashed
  • Voting queue is not getting cleared
  • In network page, connected peers information is incorrect in map (The connected peers information in the network page are incorrect in the map #3554)
  • Unable to do self voting after delegate registration. Voting is getting failed
  • Confirmations number is missing in block details page
  • Liks balance is not getting updated
  • In Lisk wallet page, Voters information gird is not listing any voters details (Removed the table since the API is not ready)
  • Transaction types distribution graph misses some tx types
  • Block filters do not work
  • The end of the date range filter should be inclusive
  • Transaction details should include block height and id
  • Round forging info changes inconsistently
  • The confirmations number in transaction details screen changes inconsistently
  • Delegates forging status chart is blank
  • Votes queue modal should allow up to 10 votes after confirmation
  • Search for account or public key is broken
  • Search for block id or tx id doesn't return response
  • Remove total LSK from delegates page
  • Remove supply from accounts page

Bitcoin wallet

  • Can't switch to BTC
  • The wallet crashes
  • Transactions table is misaligned
  • Transaction creation fails (address validation, fee calculation, ...) (BTC transaction creation fails #3555)
  • Wallet doesn't derive the address correctly
  • Balance graph is blank
  • Wallet should not show locked balance
  • tx details view crashes
  • Balance value is wrong
  • Balance is missing in dashboard
  • Network sets to mainnet when connected to customNode. It should be testnet

How was it tested?

  • Updated unit tests
  • Controlled everything visually/manually

@reyraa reyraa self-assigned this May 5, 2021
UsamaHameed
UsamaHameed previously approved these changes May 21, 2021
@UsamaHameed UsamaHameed self-requested a review May 21, 2021 10:24
@reyraa reyraa removed the request for review from isalga May 21, 2021 10:25
@reyraa reyraa merged commit 28f5c66 into development May 21, 2021
@reyraa reyraa deleted the 3535-fix-remaining-bugs branch May 21, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual issues detected in 2.0.0-alpha.7
3 participants