Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Setting domain to match the proposed architecture #4210

Closed
Tracked by #4033
reyraa opened this issue Mar 14, 2022 · 0 comments
Closed
Tracked by #4033

Refactor the Setting domain to match the proposed architecture #4210

reyraa opened this issue Mar 14, 2022 · 0 comments

Comments

@reyraa
Copy link
Contributor

reyraa commented Mar 14, 2022

Description

As a part of the Make Lisk Desktop blockchain agnostic, we should create a domain for user Settings. Said domain is responsible for collecting, storing locally, and displaying user settings.

Acceptance Criteria

According to the TECH proposal document, this domain should have components to:

  • Implement togglers that can be used by other components such as navbars, sign-in page and the main settings view.
  • Display main settings in a dedicated view.
    • Said view should use commonly reusable togglers and selectors explained above.
  • Update the local storage once a setting has been changed.
  • Inform users about saving settings.
  • Update unit and e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

5 participants