Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The signature pending step is missing in the Sign Message screen #4020

Closed
Tracked by #3963
reyraa opened this issue Dec 14, 2021 · 0 comments
Closed
Tracked by #3963

The signature pending step is missing in the Sign Message screen #4020

reyraa opened this issue Dec 14, 2021 · 0 comments
Assignees
@reyraa
Labels
type: improvement
Milestone
Sprint 65

Comments

@reyraa
Copy link
Contributor

reyraa commented Dec 14, 2021

Description

Users see a pending screen while they have to review and confirm the transaction on their HW device. For UX consistency we should add a similar screen for signing a message using HW. At the moment there's no indication of this state in the Sign Message screen.

Motivation

Disambiguate the UX.

Additional Information

This requires slight refactoring of the sign message screen and utility functions.
@ManuGowda ManuGowda added this to the Spike 3 milestone Dec 17, 2021
@ManuGowda ManuGowda modified the milestones: Spike 3, Sprint 65 Jan 1, 2022
@sridharmeganathan sridharmeganathan mentioned this issue Jan 4, 2022
Closed
37 tasks
@isalga isalga self-assigned this Jan 5, 2022
@reyraa reyraa mentioned this issue Jan 9, 2022
Merged
@ManuGowda ManuGowda assigned reyraa and unassigned isalga Jan 9, 2022
ManuGowda added a commit that referenced this issue Jan 9, 2022
@ManuGowda
Merge pull request #4050 from LiskHQ/4020-sign-message-HW-pending
fde24ca 
The signature pending step is missing in the Sign Message screen - Closes #4020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyraa reyraa

Labels
type: improvement
Projects
None yet
Milestone
Sprint 65
Development

No branches or pull requests
3 participants
@reyraa @isalga @ManuGowda