Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor JSON validation used in sign multisignature transaction modal #3533

Closed
UsamaHameed opened this issue May 5, 2021 · 0 comments · Fixed by #3677
Closed

Refactor JSON validation used in sign multisignature transaction modal #3533

UsamaHameed opened this issue May 5, 2021 · 0 comments · Fixed by #3677
Assignees
@UsamaHameed
Labels
type: improvement type: refactoring unplanned
Milestone
Sprint 53

Comments

@UsamaHameed
Copy link
Contributor

Expected behavior

The JSON validation used in the original implementation of sign multisignature modal used a custom validation function. We should refactor it to use validationTransaction() function from lisk elements.

Acceptance Criteria

  • JSON validation for all multisignature transaction types
    • Transfer
    • Vote
    • Register Delegate
    • Register Multisignature group
    • Unlock transaction
@sridharmeganathan sridharmeganathan mentioned this issue May 5, 2021
Closed
@UsamaHameed UsamaHameed self-assigned this May 25, 2021
@UsamaHameed UsamaHameed added this to the Sprint 49 milestone May 25, 2021
@UsamaHameed UsamaHameed removed this from the Sprint 50 milestone May 27, 2021
This was referenced Jun 8, 2021
Closed
Closed
@sridharmeganathan sridharmeganathan added this to the Sprint 52 milestone Jun 25, 2021
@reyraa reyraa assigned reyraa and unassigned UsamaHameed Jun 25, 2021
@UsamaHameed UsamaHameed assigned UsamaHameed and unassigned reyraa Jul 1, 2021
@UsamaHameed UsamaHameed mentioned this issue Jul 6, 2021
Merged
isalga pushed a commit that referenced this issue Jul 9, 2021
Validate JSON using validateTransaction - Closes #3533 (#3677)
7249ee1 
* add steps to valdiate the pasted transaction

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UsamaHameed UsamaHameed

Labels
type: improvement type: refactoring unplanned
Projects
None yet
Milestone
Sprint 53
Development

Successfully merging a pull request may close this issue.

Validate JSON using validateTransaction - Closes #3533 LiskHQ/lisk-desktop
3 participants
@reyraa @UsamaHameed @sridharmeganathan