-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement deployment scripts for Lisk token and Claim process smart contracts #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasKendziorra
requested changes
Nov 8, 2023
AndreasKendziorra
requested changes
Nov 9, 2023
Phanco
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
AndreasKendziorra
requested changes
Nov 10, 2023
AndreasKendziorra
requested changes
Nov 10, 2023
AndreasKendziorra
approved these changes
Nov 10, 2023
shuse2
reviewed
Nov 12, 2023
shuse2
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4.
How was it solved?
L1LiskToken
,L2LiskToken
Claim
).deployContracts.sh
) was updated to support deploying multiple contracts on L1 and L2 networks.L2LiskToken
andL2Claim
smart contracts were implemented.L2ClaimTokens
was implemented to demonstrate claiming of the tokens and transferring to the user (caller) address.How was it tested?
deployContracts.sh
script:-- L1LiskToken
-- L2LiskToken
-- Claim
-- User claimed tokens
Note
L2LiskToken
andL2Claim
smart contracts are not part of this PR and there exists separate GH issues to implement and review those two smart contracts.