-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permit
functionality to the Lisk L2 token
#11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests are really well written 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good PR! I think it all should work nicely, also the test coverage is thorough.
I have left couple of comments for discussion, but generally I accept the PR.
What was the problem?
permit
functionality for Lisk L2 token #10.How was it solved?
ERC20Permit
smart contract.755
).How was it tested?